feat: Refuse start when CEF cache is locked#257
Merged
Merged
Conversation
We frequently see that users have conflicting SyncTrayzor processes on the system, but in different locations. SyncTrayzor's IPC only triggers when processes are using the same install - but for whatever reasons some users have different SyncTrayzor processes in multiple locations using shared configurations. This can't work properly - the CEF cache is locked exclusively by the first process. This then causes a CEF init failure, with a fairly generic error message that doesn't explain what's going on. Try to detect such a scenario by locking the file first - if that fails, we know another process already has that config. Explain the problem to the user and refuse startup in such a case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We frequently see that users have conflicting SyncTrayzor processes on the system, but in different locations. SyncTrayzor's IPC only triggers when processes are using the same install - but for whatever reasons some users have different SyncTrayzor processes in multiple locations using shared configurations. This can't work properly - the CEF cache is locked exclusively by the first process.
This then causes a CEF init failure, with a fairly generic error message that doesn't explain what's going on. Try to detect such a scenario by locking the file first - if that fails, we know another process already has that config. Explain the problem to the user and refuse startup in such a case.