Skip to content

CRNS-17: add react-native-navigation to example app and CRNS-149: add multi-file/image upload support#312

Merged
virdesai merged 12 commits into
masterfrom
CRNS-149,CRNS-17/multiple-file-upload-and-react-native-navigation-example
Sep 11, 2020
Merged

CRNS-17: add react-native-navigation to example app and CRNS-149: add multi-file/image upload support#312
virdesai merged 12 commits into
masterfrom
CRNS-149,CRNS-17/multiple-file-upload-and-react-native-navigation-example

Conversation

@virdesai
Copy link
Copy Markdown
Contributor

@virdesai virdesai commented Sep 4, 2020

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

  • CRNS-17: upgrade NativeMessaging app to latest RN version (0.63.2) and added in latest version of react-native-navigation
  • CRNS-149: adding support for multi document upload with existing repo but upgraded and multi image upload using react-native-image-crop-picker

CRNS-17: upgrade NativeMessaging app to latest RN version (0.63.2) an…
67f99b5 
…d added in latest version of react-native-navigation. CRNS-149: adding support for multi document upload with existing repo but upgraded and multi image upload using react-native-image-crop-picker
vishalnarkhede
vishalnarkhede requested changes Sep 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vishalnarkhede vishalnarkhede left a comment •
edited by virdesai
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread native-package/package.json Outdated
Comment thread native-package/package.json
"react-native-document-picker": ">=3.2.0",
"react-native-image-picker": ">=0.28.1",
"react-native-document-picker": ">=3.5.4",
"react-native-image-crop-picker": ">=0.33.2",
Copy link
Copy Markdown
Contributor

@vishalnarkhede vishalnarkhede Sep 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutorial will have to be updated as well.

Comment thread native-package/src/index.js Outdated
Comment thread native-package/src/index.js
This was linked to issues Sep 4, 2020
Crash on image upload - Missing request token on react-native 0.63 #241
Closed
Image Uploads totally inconsistent #180
Closed
@virdesai virdesai added Dependencies Pull requests that update a dependency file Enhancement New feature or request labels Sep 4, 2020
Vir Desai added 4 commits September 4, 2020 11:13
updating some docs. adding context to NativeMessaging example. settin…
54f3985 
…g minimum RN version for native-package. using maxNumberOfFiles prop for document and image picker. added compressImageQuality prop to MessageInput to use with react-native-image-crop-picker
Merge branch 'master' of https://github.com/GetStream/stream-chat-rea…
3718199 
…ct-native into CRNS-149,CRNS-17/multiple-file-upload-and-react-native-navigation-example
center header title across screens for android and iOS in NativeMessa…
54e41c1 
…ging example app
removing warning from example app
cf10f34
Vir Desai added 3 commits September 8, 2020 10:05
vishalnarkhede
vishalnarkhede approved these changes Sep 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vishalnarkhede vishalnarkhede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalnarkhede
Copy link
Copy Markdown
Contributor

vishalnarkhede commented Sep 10, 2020

Should we let all the components go in first as 1.3.0 and then merge this as next one?

@virdesai
Copy link
Copy Markdown
Contributor Author

virdesai commented Sep 10, 2020

Should we let all the components go in first as 1.3.0 and then merge this as next one?

sure we can wait if you want. it's built off of whatever we have but nbd if we wait

@jackpordi
Copy link
Copy Markdown

jackpordi commented Sep 10, 2020

Any estimate as to when this might be merged/released?

@virdesai
Copy link
Copy Markdown
Contributor Author

virdesai commented Sep 10, 2020

Any estimate as to when this might be merged/released?

@jackel119 waiting on #311 to be merged first and it's almost ready so hopefully today/tomorrow

@virdesai virdesai merged commit 0f3196d into master Sep 11, 2020
@delete-merged-branch delete-merged-branch Bot deleted the CRNS-149,CRNS-17/multiple-file-upload-and-react-native-navigation-example branch September 11, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

@nhannah nhannah Awaiting requested review from nhannah

@DanC5 DanC5 Awaiting requested review from DanC5

Assignees

No one assigned

Labels

Dependencies Pull requests that update a dependency file Enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash on image upload - Missing request token on react-native 0.63 Image Uploads totally inconsistent

3 participants

@virdesai @vishalnarkhede @jackpordi