Integrate Client Error Event Reporting#1686
Draft
rahul-lohra wants to merge 14 commits into
Draft
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Integrate Client Error Event Reporting
Implementation
Core changes
API Layer Classes
Endpoint
Request Body
CallLeaveReason
Major Internal Change
Telemetry Logic
ClientEventReporter Overview
Responsibilities
Core State
inFlightSessionsevent_session_idjoinStageAttemptIdMapcallSessionIdMapcall_session_idper callbatchEventsactivePcSessionIdspcEverConnectedCONNECTEDMain Reporting APIs
reportCoordinatorJoinInitiatedreportCoordinatorJoinCompletedreportWsJoinInitiatedreportWsJoinCompletedonPeerConnectionIceStateChangedcompletePeerConnectionSessionabortAllInFlightsendAllPendingEventsDelivery Strategies
IN_PLACEBATCHPeerConnection Telemetry Flow
CHECKINGCONNECTEDFAILEDInternal Design Notes
event_session_iduniquely identifies a telemetry sessionINITIATED → COMPLETEDevents🎨 UI Changes
None
Testing
TODO