Skip to content

Development improvements#142

Merged
tomaslink merged 1 commit intomainfrom
PIPELINE-3679-pipe-events-push-docker-image-to-new-registry
Mar 6, 2026
Merged

Development improvements#142
tomaslink merged 1 commit intomainfrom
PIPELINE-3679-pipe-events-push-docker-image-to-new-registry

Conversation

@tomaslink
Copy link
Contributor

@tomaslink tomaslink commented Mar 4, 2026 •
edited
Loading

In this PR we include several small changes:

  • Start using the cloudbuild trigger from terraform-gcp-modules repository.
  • Compile dependencies using pip-tools.
  • Add Makefile.
  • Add git workflow documentation.
  • Improves GitHub actions.
  • Improve Dockerfile.
  • Leaves everything ready to migrate to Python 3.12.

https://globalfishingwatch.atlassian.net/browse/PIPELINE-3679

@tomaslink tomaslink self-assigned this Mar 4, 2026
@tomaslink tomaslink force-pushed the PIPELINE-3679-pipe-events-push-docker-image-to-new-registry branch 10 times, most recently from 8ca6f84 to 5f9a313 Compare March 4, 2026 23:16
@tomaslink tomaslink changed the title Add cloudbuild trigger, Makefile, and git workflow docs Several improvements (cloudbuild trigger, Makefile, and git workflow docs, etc) Mar 4, 2026
@tomaslink tomaslink changed the title Several improvements (cloudbuild trigger, Makefile, and git workflow docs, etc) Small development improvements Mar 4, 2026
@tomaslink tomaslink changed the title Small development improvements Development improvements Mar 4, 2026
@tomaslink tomaslink force-pushed the PIPELINE-3679-pipe-events-push-docker-image-to-new-registry branch from 5f9a313 to 99d3aad Compare March 4, 2026 23:23
tomaslink
tomaslink commented Mar 4, 2026
View reviewed changes
rdgfuentes
rdgfuentes approved these changes Mar 5, 2026
View reviewed changes
Copy link
Contributor

@rdgfuentes rdgfuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aperdizs
aperdizs approved these changes Mar 6, 2026
View reviewed changes
Copy link
Contributor

@aperdizs aperdizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Great job Tom! :)

@tomaslink tomaslink merged commit 0bd4427 into main Mar 6, 2026
4 checks passed
@tomaslink tomaslink deleted the PIPELINE-3679-pipe-events-push-docker-image-to-new-registry branch March 6, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrequero rrequero Awaiting requested review from rrequero

@andres-arana andres-arana Awaiting requested review from andres-arana

@smpiano smpiano Awaiting requested review from smpiano

@aperdizs aperdizs Awaiting requested review from aperdizs

@rdgfuentes rdgfuentes Awaiting requested review from rdgfuentes

Assignees

@tomaslink tomaslink

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomaslink @rdgfuentes @aperdizs