Goodbridge page by Gutopro · Pull Request #631 · GoodDollar/GoodProtocolUI

Gutopro · 2026-04-01T16:11:21Z

Description

This PR integrates the MessagePassingBridge

About #628

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

Summary by Sourcery

Add a new Good Bridge page integrating the MessagePassingBridge flow and expose it in navigation with feature flag control across supported networks.

New Features:

Introduce a Good Bridge page that embeds the MessagePassingBridge controller within the existing PageLayout.
Add a Good Bridge navigation entry and route, gated by a dedicated feature flag per network.

Enhancements:

Extend feature flag configuration to support enabling or disabling the Good Bridge per supported chain.

sourcery-ai

Hey - I've left some high level feedback:

The new goodBridgeEnabled feature flag is configured in useFeaturesEnabled but not actually used for the sidebar entry or route visibility, so consider wiring it through (similar to microBridgeEnabled) to control when /goodbridge is shown.
There is an index.tsx~ file added under src/pages/gd/GoodBridge/ that looks like an editor backup and should probably be removed from the PR.
The Good Bridge sidebar item currently reuses the bridgeEnabled condition (!isMinipay || bridgeEnabled), which may be tied to the micro-bridge; consider using a distinct check aligned with goodBridgeEnabled to avoid coupling the two features.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `goodBridgeEnabled` feature flag is configured in `useFeaturesEnabled` but not actually used for the sidebar entry or route visibility, so consider wiring it through (similar to `microBridgeEnabled`) to control when `/goodbridge` is shown.
- There is an `index.tsx~` file added under `src/pages/gd/GoodBridge/` that looks like an editor backup and should probably be removed from the PR.
- The `Good Bridge` sidebar item currently reuses the `bridgeEnabled` condition (`!isMinipay || bridgeEnabled`), which may be tied to the micro-bridge; consider using a distinct check aligned with `goodBridgeEnabled` to avoid coupling the two features.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Gutopro · 2026-04-01T16:40:11Z

hi @L03TJ3 here's the new PR also here's my wallet address
0x8798790bd86170C1F5bF9d681E9038Be94C4B71F

L03TJ3 · 2026-04-02T17:19:03Z

@Gutopro Send you some CELO.
set the bridge to development environment.
you can claim dev G$'s on Celo on: dev.gooddapp.org

That should give you enough to bridge from Celo > Fuse or XDC

Gutopro · 2026-04-03T20:38:40Z

@Gutopro Send you some CELO. set the bridge to development environment. you can claim dev G$'s on Celo on: dev.gooddapp.org

That should give you enough to bridge from Celo > Fuse or XDC

thanks @L03TJ3 ive seen the Celo, how can i set my bridge to development please?

Gutopro · 2026-04-03T21:02:09Z

also just a few things

i cant claim G$, the facial verification fails with an error saying login information is missing
i'm using meta mask, when i connect my wallet to the bridge my balance isnt reflected on the page but the wallet connects successfully.

@L03TJ3

Gutopro · 2026-04-06T11:47:34Z

Hi @L03TJ3 any updates on this?

Gutopro · 2026-04-07T08:39:51Z

@L03TJ3 it's been awhile and I haven't gotten any feedback from you

L03TJ3 · 2026-04-07T09:31:48Z

Up for review today, weekend in the middle

L03TJ3 · 2026-04-07T10:43:17Z

@Gutopro

make sure to initially claim the dev G$'s on https://dev.gooddapp.org
locally you will have to setup the .env file and if you followed this instructions: Feat: integrate the MessagePassingBridge #628 (comment)
your local dapp should already be set up to the development-environment.

If you have not been able to claim dev G$'s, what would you expect your balance to show/be?

Gutopro · 2026-04-07T11:33:08Z

I tried claiming the G$ but the verification keeps failing just like in the screenshot I shared earlier

L03TJ3 · 2026-04-07T12:39:59Z

@Gutopro I just tried and it worked, I don't get the 'information missing' screen.
so you'll need to provide a bit more details so I can assist better.
what can also help is a video demonstrating the flow and issue

Gutopro · 2026-04-07T16:26:30Z

here's a link to the video on loom.
https://www.loom.com/share/23046953a3ca4ac8b3a7a78834b2c1c2

initially the facial verification wouldnt work but on this try it did, then it failed at the location verification as seen in the video, i'm not using any vpn so i wonder why it wouldnt work.
@L03TJ3

L03TJ3 · 2026-04-07T17:24:19Z

@Gutopro Okay, confirmed the bug on my side too. I have disabled this flow now. if you clear your cache/hard refresh the claim page you should be able to claim

Gutopro · 2026-04-07T21:28:08Z

thank you. i was able to get the G$. i made a test video demonstrating my progress with the page so far and this is what i have
https://www.loom.com/share/c662ff9ee30440d48071a8ddfe784293
@L03TJ3

Gutopro · 2026-04-08T15:45:55Z

Any comments on this? @L03TJ3

Gutopro · 2026-04-10T07:24:01Z

Hi @L03TJ3 I tried reaching you on telegram but I couldnt, it told me I could only text a mutual contact. As seen in the video on the Good bridge page the bridge assets button doesn't work on click. Can you have a look at it?

L03TJ3 · 2026-04-10T09:04:33Z

@Gutopro You can always reach out to me in the public channels by pinging: @demewlingoak
there should be no issue to contact me, more people approach me wihtout me knowing them
Might be a configuration on your side that prevents it

Will have a look in a bit

L03TJ3 · 2026-04-10T15:38:29Z

.... right...

My bad, apologies. forgot we never released dev contracts for the message-passing-bridge.
you need to set your .env to 'production-celo' and use production G$'s.. @Gutopro

Gutopro · 2026-04-10T15:51:17Z

Thanks @L03TJ3 however isn't production G$ real G$? I don't have that.

L03TJ3 · 2026-04-10T16:26:43Z

@Gutopro send you some on this address: 0x8798790bd86170C1F5bF9d681E9038Be94C4B71F

Gutopro · 2026-04-10T17:00:15Z

Thank you @L03TJ3 I'll keep you updated on my progress

Gutopro · 2026-04-11T20:29:49Z

https://www.loom.com/share/7cb4dbd6c37243d9963c6211fd69bde0
it works now @L03TJ3

Gutopro · 2026-04-13T18:21:38Z

@L03TJ3 can you have a look at this please> https://www.loom.com/share/7cb4dbd6c37243d9963c6211fd69bde0

it works now @L03TJ3

Gutopro · 2026-04-14T13:34:15Z

@L03TJ3 please any updates on this?

Gutopro · 2026-04-16T10:44:40Z

Hi @L03TJ3 it's been a while. I messaged you on telegram but I didn't get a response. Could you please review this and provide feedback?

L03TJ3

For the rest, looks good

L03TJ3 · 2026-04-17T12:25:01Z

+                    {
+                        route: '/goodbridge',
+                        text: 'Good Bridge',
+                        show: !isMinipay || goodBridgeEnabled,
+                    },


Lets make GoodBridge (one word, no space) the first on in the side-bar list.
and rename microbridge to > Fuse/Celo Bridge

to make the distinction between the two a bit more clear.
its fine to only change the UI/display name, does not have to be renamed everywhere

Gutopro · 2026-04-17T14:06:51Z

Hi @L03TJ3 I've made the changes could you please have a look at it?

* fix: bump sdk-v2 with reserve fix * Fix: Restore claim disabled message modal overlay (#611) (#626) * fix: replace useModal with absolute overlay for disabled claim state * fix: gate modal display with claimEnabled flag and remove comments * fix: use standard img tag to ensure maintenance asset renders * chore: restore valid developer comments and remove temporary ones * fixes: insufficient gas error message, disconnect after reload, cached approval amount * chore: lingui * include xdc production contracts * fix: also update gd web3-mono dependencies with goodprotocol xdc prod contracts * chore: release qa version 1.119.0 [skip build] * chore: release qa version 1.120.0 [skip build] * chore: release prod version 1.121.0 [skip build] * fix: enforce reconnect for stale web3-onboard connections * fix: remove legacy model open call * fix: add option to exclude rpcs that are not working, configure through env * temp-fix: default to show celo price * chore: lingui * chore: release qa version 1.122.0 [skip build] * chore: release prod version 1.123.0 [skip build] * fix: stop forcing celo gas price (#632) * fix: stop forcing celo gas price * chore: bump gooddollar sdks --------- Co-authored-by: LewisB <lewis@ikigaistudios.eu> * chore: release qa version 1.124.0 [skip build] * chore: release prod version 1.125.0 [skip build] * Goodbridge page (#631) * add GoodBridge page to src/pages/gd * update sideBar.tsx * feat: implement GoodBridge route and update connect wallet copy * Delete src/pages/gd/GoodBridge/index.tsx~ * Add goodBridgeEnabled to payload destructuring * Fix typo in goodBridgeEnabled variable * Update bridge names in SideBar component * dont estimate gas on minipay * remove duplicate key for layerzero bridge feature enabled * chore: lingui * enable lzbridge on dev * bump vercel to fix gh actions deployments * chore: lingui * chore: release qa version 1.126.0 [skip build] * chore: release qa version 1.127.0 [skip build] * chore: release prod version 1.128.0 [skip build] * feat: integrate savings widget and update FAQ section * made corrections * effected necessary changes * Update src/components/SideBar.tsx --------- Co-authored-by: LewisB <lewis@gooddollar.org> Co-authored-by: Victor Edeh <edehvictor715@gmail.com> Co-authored-by: Techadmin <techadmin@gooddollar.org> Co-authored-by: sirpy <hadar@gooddollar.org> Co-authored-by: LewisB <lewis@ikigaistudios.eu> Co-authored-by: Nicholas Igber <111025771+Gutopro@users.noreply.github.com>

Gutopro added 3 commits March 24, 2026 13:02

add GoodBridge page to src/pages/gd

f20088b

update sideBar.tsx

393ce5b

feat: implement GoodBridge route and update connect wallet copy

3b9177c

Gutopro had a problem deploying to external April 1, 2026 16:11 — with GitHub Actions Failure

sourcery-ai Bot reviewed Apr 1, 2026

View reviewed changes

Delete src/pages/gd/GoodBridge/index.tsx~

12e8e3b

Gutopro had a problem deploying to external April 1, 2026 16:15 — with GitHub Actions Failure

Add goodBridgeEnabled to payload destructuring

991dc38

Gutopro had a problem deploying to external April 1, 2026 16:26 — with GitHub Actions Failure

Fix typo in goodBridgeEnabled variable

7923fa6

Gutopro temporarily deployed to external April 1, 2026 16:29 — with GitHub Actions Inactive

L03TJ3 linked an issue Apr 2, 2026 that may be closed by this pull request

Feat: integrate the MessagePassingBridge #628

Open

10 tasks

L03TJ3 requested changes Apr 17, 2026

View reviewed changes

Gutopro deployed to preview April 17, 2026 12:43 — with GitHub Actions Active

Update bridge names in SideBar component

53a7555

Gutopro had a problem deploying to external April 17, 2026 14:05 — with GitHub Actions Failure

L03TJ3 self-requested a review April 23, 2026 15:39

L03TJ3 approved these changes Apr 23, 2026

View reviewed changes

L03TJ3 merged commit 8b4f4ff into GoodDollar:master Apr 23, 2026
2 of 3 checks passed

Conversation

Gutopro commented Apr 1, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Summary by Sourcery

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Gutopro commented Apr 1, 2026

Uh oh!

L03TJ3 commented Apr 2, 2026

Uh oh!

Gutopro commented Apr 3, 2026

Uh oh!

Gutopro commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gutopro commented Apr 6, 2026

Uh oh!

Gutopro commented Apr 7, 2026

Uh oh!

L03TJ3 commented Apr 7, 2026

Uh oh!

L03TJ3 commented Apr 7, 2026

Uh oh!

Gutopro commented Apr 7, 2026

Uh oh!

L03TJ3 commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gutopro commented Apr 7, 2026

Uh oh!

L03TJ3 commented Apr 7, 2026

Uh oh!

Gutopro commented Apr 7, 2026

Uh oh!

Gutopro commented Apr 8, 2026

Uh oh!

Gutopro commented Apr 10, 2026

Uh oh!

L03TJ3 commented Apr 10, 2026

Uh oh!

L03TJ3 commented Apr 10, 2026

Uh oh!

Gutopro commented Apr 10, 2026

Uh oh!

L03TJ3 commented Apr 10, 2026

Uh oh!

Gutopro commented Apr 10, 2026

Uh oh!

Gutopro commented Apr 11, 2026

Uh oh!

Gutopro commented Apr 13, 2026

Uh oh!

Gutopro commented Apr 14, 2026

Uh oh!

Gutopro commented Apr 16, 2026

Uh oh!

L03TJ3 left a comment

Choose a reason for hiding this comment

Uh oh!

L03TJ3 Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Gutopro commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Gutopro commented Apr 1, 2026 •

edited by sourcery-ai Bot

Loading

Gutopro commented Apr 3, 2026 •

edited

Loading

L03TJ3 commented Apr 7, 2026 •

edited

Loading