Skip to content

Modified the script to be compatible with new K8S version#1050

Open
jayadeep-jayaraman wants to merge 24 commits into
mainfrom
k8s-upgrade
Open

Modified the script to be compatible with new K8S version#1050
jayadeep-jayaraman wants to merge 24 commits into
mainfrom
k8s-upgrade

Conversation

@jayadeep-jayaraman

Copy link
Copy Markdown
Collaborator

No description provided.

@jayadeep-jayaraman

jayadeep-jayaraman commented Feb 17, 2023

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@jayadeep-jayaraman

jayadeep-jayaraman commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@jayadeep-jayaraman

jayadeep-jayaraman commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@cjac cjac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Feel free to respond to my questions or comments in the comments after you merge.

LOGS_SINCE_TIME=$(date --iso-8601=seconds)
done


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this new newline is probably not necessary

--env="COMMIT_SHA=${COMMIT_SHA}" \
--env="IMAGE_VERSION=${DATAPROC_IMAGE_VERSION}" \
--command -- bash /init-actions/cloudbuild/presubmit.sh
#kubectl run "${POD_NAME}" \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this old command in the previous commit in the main branch. Thank you for preserving the previous implementation in comments. I loathe the concept of removing the old implementation as well. We could leave this comment in for the next release for posterity and then remove them to reduce file size and execution time.

- 'COMMIT_SHA=$COMMIT_SHA'
- 'CLOUDSDK_COMPUTE_REGION=us-central1'
- 'CLOUDSDK_CONTAINER_CLUSTER=init-actions-presubmit'
# # Run presubmit tests in parallel for 2.0 Rocky Linux image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, leave the comments for posterity for one release and then remove them to reduce file size and execution time

- 'CLOUDSDK_COMPUTE_REGION=us-central1'
- 'CLOUDSDK_CONTAINER_CLUSTER=init-actions-presubmit'

# # Run presubmit tests in parallel for 1.5 Debian image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the previous/next two comments. leave comments for one PR and remove them in the next to reduce file size and execution time.

Comment thread cloudbuild/Dockerfile
RUN echo "deb [arch=amd64] http://storage.googleapis.com/bazel-apt stable jdk1.8" | tee /etc/apt/sources.list.d/bazel.list
RUN curl https://bazel.build/bazel-release.pub.gpg | apt-key add -
RUN apt-get update && apt-get install -y openjdk-8-jdk python3-setuptools bazel
RUN apt-get update && apt-get install -y openjdk-8-jdk python3-setuptools bazel gettext-base

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems fine. I don't see it being used below, but perhaps the kubectl apply depends on this for translation. Can you share why we included this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants