Skip to content

Update dependency com.google.cloud:google-cloud-datastore to v2.32.2 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 6, 2025
Merged

Update dependency com.google.cloud:google-cloud-datastore to v2.32.2 #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions applications/proberapp/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<DB_REGION>us-central1</DB_REGION>
<DB_USER>prober-user</DB_USER>
<DB_PASSOWRD>prober_connectivity_test_database</DB_PASSOWRD>
<gax.version>2.70.2</gax.version>
<gax.version>2.70.3</gax.version>
<appengine.target.version>${project.version}</appengine.target.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<appengine.runtime.location>target/${project.artifactId}-${project.version}</appengine.runtime.location>
Expand Down Expand Up @@ -123,12 +123,12 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-core</artifactId>
<version>2.60.2</version>
<version>2.60.3</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-datastore</artifactId>
<version>2.32.1</version>
<version>2.32.2</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
Expand Down Expand Up @@ -221,7 +221,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<!-- TODO it would good to have this version only in pluginManagement in top pom -->
<version>3.8.1</version>
<version>3.9.0</version>
Comment on lines 222 to +224
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

As the TODO comment on line 223 suggests, it would be better to manage the version of maven-dependency-plugin in the <pluginManagement> section of the root pom.xml. This version is duplicated in several modules (jetty121_assembly/pom.xml, jetty12_assembly/pom.xml, sdk_assembly/pom.xml).

Centralizing the version in the parent POM would improve maintainability and ensure consistency across the project. You could add this plugin to <pluginManagement> in the root pom.xml and then remove the <version> tag from all child modules.

<executions>
<execution>
<id>copy-file</id>
Expand Down Expand Up @@ -278,7 +278,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.6.1</version>
<version>3.6.2</version>
<executions>
<execution>
<id>enforce-maven</id>
Expand Down
2 changes: 1 addition & 1 deletion jetty121_assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.8.1</version>
<version>3.9.0</version>
<executions>
<execution>
<id>unpack</id>
Expand Down
2 changes: 1 addition & 1 deletion jetty12_assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.8.1</version>
<version>3.9.0</version>
<executions>
<execution>
<id>unpack</id>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.6.1</version>
<version>3.6.2</version>
Comment on lines 760 to +761
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for maven-enforcer-plugin is duplicated in applications/proberapp/pom.xml. To avoid this duplication and improve maintainability, consider moving this plugin's version management to the <pluginManagement> section of this file. After that, you can remove the explicit <version> tag from the <build><plugins> sections where this plugin is used.

<executions>
<execution>
<id>enforce-maven</id>
Expand Down
2 changes: 1 addition & 1 deletion sdk_assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
</plugin>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.8.1</version>
<version>3.9.0</version>
<executions>
<execution>
<id>unpack</id>
Expand Down
Loading