Skip to content

Update all non-major dependencies #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 10, 2025
Merged

Update all non-major dependencies #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine-api-1.0-sdk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<dependency> <!-- needed for remote_api for opencensus. -->
<groupId>io.grpc</groupId>
<artifactId>grpc-api</artifactId>
<version>1.75.0</version>
<version>1.76.0</version>
<optional>true</optional>
</dependency>
<dependency>
Expand Down
8 changes: 4 additions & 4 deletions applications/proberapp/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-spanner</artifactId>
<version>6.101.1</version>
<version>6.102.0</version>
</dependency>
<dependency>
<groupId>com.google.appengine</groupId>
Expand Down Expand Up @@ -118,7 +118,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigquery</artifactId>
<version>2.55.1</version>
<version>2.55.2</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
Expand All @@ -133,12 +133,12 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-logging</artifactId>
<version>3.23.5</version>
<version>3.23.6</version>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Maintainability: Redundant Version Specification

The version for the com.google.cloud:google-cloud-logging dependency is already managed in the dependencyManagement section of the root pom.xml (lines 709-713).

Specifying the version here is redundant and goes against Maven best practices for centralized dependency management. It can lead to inconsistencies if the parent POM is updated and this file is not.

It's recommended to remove this explicit version declaration and let it be inherited from the parent POM. This will make dependency version management more robust and less error-prone.

</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-storage</artifactId>
<version>2.58.0</version>
<version>2.58.1</version>
</dependency>
<dependency>
<groupId>com.google.cloud.sql</groupId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-logging</artifactId>
<version>3.23.5</version>
<version>3.23.6</version>
</dependency>
</dependencies>
</dependencyManagement>
Expand Down
Loading