update variables files for gke nodepool taints#1358
Merged
ludoo merged 4 commits intoGoogleCloudPlatform:masterfrom May 5, 2023
Merged
update variables files for gke nodepool taints#1358ludoo merged 4 commits intoGoogleCloudPlatform:masterfrom
ludoo merged 4 commits intoGoogleCloudPlatform:masterfrom
Conversation
Collaborator
|
Thanks for the fix! You have to run the tfdoc script to update the README file. |
ludoo
approved these changes
May 5, 2023
Collaborator
ludoo
left a comment
ludoo
left a comment
There was a problem hiding this comment.
Thanks for spotting this!
juliocc
approved these changes
May 5, 2023
Author
|
Just noticed the readme issue, getting setup and will add my commit with the changes shortly. |
Author
Collaborator
|
You should see a merge button, just go a ahead and merge. :) |
Author
No merge button sorry, unless im being extremely dense. |
Collaborator
|
ach, my fault... let me merge, sorry for that and thanks for the PR |
lcaggio
pushed a commit
that referenced
this pull request
May 5, 2023
* update variables files for gke node config taints to allow passing of node objects * forgot to run terraform fmt.. * update module docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
A small fix to the gke blueprint, and the fast gke module to allow passing of taint objects down through the modules.