Add managed folders support to gcs module#2530
Merged
Conversation
juliocc
changed the title
gcs modulesgcs module
juliocc
changed the title
gcs modulegcs module
juliocc
force-pushed
the
jccb/gcs-updates
branch
from
805ca37 to
74d380f
Compare
ludoo
approved these changes
Aug 27, 2024
Collaborator
ludoo
left a comment
ludoo
left a comment
There was a problem hiding this comment.
very nice, my only nit is on Keys must end in /, can we interpolate it and have more readable keys? ignore me ofc if the current approach makes more sense
Collaborator
Author
Removed the need for the trailing / |
juliocc
changed the title
gcs modulegcs module
juliocc
force-pushed
the
jccb/gcs-updates
branch
from
9e6370e to
cef877d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iam_by_principals