Skip to content

chore: update linkage tests #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burkedavison merged 8 commits into from
Nov 10, 2023
Merged

chore: update linkage tests #2358

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d76bb75
chore: fake update
burkedavison Nov 9, 2023
2942078
chore: @Ignore LinkageCheckerMainIntegrationTest.testBom_java11
burkedavison Nov 9, 2023
38545ac
chore: change expected linkage errors in grpc-netty-shaded from 4 to 5
burkedavison Nov 9, 2023
b01a24b
chore: change expected Linkage Checker rule errors in bom-project-usi…
burkedavison Nov 9, 2023
17260a8
chore: relocate linkage error assertion to JDK-version specific test
burkedavison Nov 9, 2023
bf75844
chore: update LinkageCheckerMainIntegrationTest expected error count
burkedavison Nov 10, 2023
605b808
chore: remove unused import
burkedavison Nov 10, 2023
a45e865
chore: remove outdated comments
burkedavison Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: @ignore LinkageCheckerMainIntegrationTest.testBom_java11
  • Loading branch information
@burkedavison
burkedavison committed Nov 9, 2023
commit 29420781b516b9a0b51303f5ebb1e9cb73b278c0
4 changes: 4 additions & 0 deletions ...t/java/com/google/cloud/tools/opensource/classpath/LinkageCheckerMainIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.junit.After;
import org.junit.Assume;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;

public class LinkageCheckerMainIntegrationTest {
Expand Down Expand Up @@ -160,6 +161,9 @@ public void testBom_java8()
}

@Test
@Ignore("Began failing after Oct 4, 2023 and before Nov 9, 2023 without source changes")
// Error: expected:<Found 75[6] linkage errors> but was:<Found 75[8] linkage errors>
// No previous list of 756 expected linkage errors exists to compare against the new error count.
public void testBom_java11()
throws IOException, RepositoryException, TransformerException, XMLStreamException {
// The number of linkage errors differs between Java 8 and Java 11 runtime.
Expand Down