feat: support new output-only field dns_names for Cloud SQL instances

[wuchris-g]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: added output-only field `dns_names` to `google_sql_database_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[wuchris-g]

terraform show displays the new field:

dns_name                       = "3661cef6ee3b.3byu56ye5ycsb.us-central1.sql.goog."
dns_names                      = [
        {
            connection_type = "PUBLIC"
            dns_scope       = "INSTANCE"
            name            = "3661cef6ee3b.3byu56ye5ycsb.us-central1.sql.goog."
        },
]
...

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 46 insertions(+))
google-beta provider: Diff ( 4 files changed, 46 insertions(+))

[modular-magician]

Tests analytics

Total tests: 107
Passed tests: 85
Skipped tests: 21
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_useCasBasedServerCa

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_useCasBasedServerCa [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[zli82016]

Also, the test failed. Is this new field supported now?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 107
Passed tests: 85
Skipped tests: 21
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_useCasBasedServerCa

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_useCasBasedServerCa [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[zli82016]

The new field is not in GA yet. I am going to run the test again on April 16 to check if the test passes or not.

[github-actions]

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 111
Passed tests: 89
Skipped tests: 21
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_useCasBasedServerCa

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_useCasBasedServerCa [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[zli82016]

/gcbrun

[zli82016]

The test TestAccSqlDatabaseInstance_useCasBasedServerCa passed in Teamcity
https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_SQL/360198?buildTab=tests

[zli82016]

The ramping up to GA is finished.