framework compute network datasource#13567
framework compute network datasource#13567c2thorn merged 2 commits intoGoogleCloudPlatform:FEATURE-BRANCH-plugin-frameworkfrom
Conversation
34afbba to
2ad828a
Compare
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4789 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
NickElliot
left a comment
There was a problem hiding this comment.
minor formatting but looks good within the caveat of not having the more complex types supported
Co-authored-by: Nick Elliot <nickelliot@google.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4789 Click here to see the affected service packages
Action takenFound 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label |
a963ebb
into
GoogleCloudPlatform:FEATURE-BRANCH-plugin-framework
comparison with regular data source output: gpaste/6438323367968768
this is made test-only
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.