Adding Memcache Instance datasource by NA2047 · Pull Request #13591 · GoogleCloudPlatform/magic-modules

NA2047 · 2025-04-08T19:28:25Z

Release Note Template for Downstream PRs (will be copied)

`google_memcache_instance`

github-actions · 2025-04-08T19:29:23Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-04-08T19:37:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 168 insertions(+))
google-beta provider: Diff ( 4 files changed, 168 insertions(+))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2025-04-08T19:39:41Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccMemcacheInstanceDatasourceConfig
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-04-08T19:54:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 167 insertions(+))
google-beta provider: Diff ( 4 files changed, 167 insertions(+))

modular-magician · 2025-04-08T19:57:34Z

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-08T20:11:44Z

🟢 Tests passed during RECORDING mode:
TestAccMemcacheInstanceDatasourceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-04-08T22:22:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 167 insertions(+))
google-beta provider: Diff ( 4 files changed, 167 insertions(+))

modular-magician · 2025-04-08T22:25:31Z

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2025-04-11T09:42:30Z

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

melinath

moved to inline

modular-magician · 2025-04-16T23:13:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 170 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2025-04-16T23:14:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 170 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2025-04-16T23:15:41Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccMemcacheInstanceDatasourceConfig
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-04-16T23:16:46Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccMemcacheInstanceDatasourceConfig
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-04-17T05:08:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 173 insertions(+))
google-beta provider: Diff ( 4 files changed, 173 insertions(+))

modular-magician · 2025-04-17T05:10:51Z

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-17T05:25:21Z

🟢 Tests passed during RECORDING mode:
TestAccMemcacheInstanceDatasourceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-04-17T16:10:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 173 insertions(+))
google-beta provider: Diff ( 4 files changed, 173 insertions(+))

modular-magician · 2025-04-17T16:13:41Z

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2025-04-21T09:43:17Z

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-04-23T09:42:51Z

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

melinath

one small change, otherwise lgtm

…che_instance_test.go

modular-magician · 2025-04-23T16:45:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 170 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+))

modular-magician · 2025-04-23T16:48:10Z

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

First commit

934b7de

github-actions bot requested a review from melinath April 8, 2025 19:29

modular-magician added the service/memcache label Apr 8, 2025

Updating tests

7dff52d

NA2047 force-pushed the memcacheDatasource branch from 239d2a5 to 7dff52d Compare April 8, 2025 19:43

Fixing Docs

7aa03c5

melinath reviewed Apr 14, 2025

View reviewed changes

melinath requested changes Apr 14, 2025

View reviewed changes

Comment thread mmv1/third_party/terraform/services/memcache/data_source_memcache_instance_test.go

github-actions bot requested a review from melinath April 16, 2025 23:02

NA2047 force-pushed the memcacheDatasource branch from 45cd957 to 202b907 Compare April 16, 2025 23:03

NA2047 force-pushed the memcacheDatasource branch from 202b907 to e5b1b19 Compare April 17, 2025 04:56

Updated based on PR comments

199686b

NA2047 force-pushed the memcacheDatasource branch from e5b1b19 to 199686b Compare April 17, 2025 15:58

melinath requested changes Apr 23, 2025

View reviewed changes

Comment thread mmv1/third_party/terraform/services/memcache/data_source_memcache_instance_test.go Outdated

Update mmv1/third_party/terraform/services/memcache/data_source_memca…

7e1442f

…che_instance_test.go

github-actions bot requested a review from melinath April 23, 2025 16:35

melinath approved these changes Apr 23, 2025

View reviewed changes

melinath added this pull request to the merge queue Apr 23, 2025

Merged via the queue into GoogleCloudPlatform:main with commit f4add30 Apr 23, 2025
21 checks passed

This was referenced Apr 23, 2025

Adding Memcache Instance datasource hashicorp/terraform-provider-google#22477

Merged

Adding Memcache Instance datasource hashicorp/terraform-provider-google-beta#9864

Merged

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 26, 2025

Adding Memcache Instance datasource (GoogleCloudPlatform#13591)

b01c4d5

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Apr 28, 2025

Adding Memcache Instance datasource (GoogleCloudPlatform#13591)

90dea74

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 13, 2025

Adding Memcache Instance datasource (GoogleCloudPlatform#13591)

7a09637

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025

Adding Memcache Instance datasource (GoogleCloudPlatform#13591)

a8241b1

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Conversation

NA2047 commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

modular-magician commented Apr 8, 2025

Diff report

Errors

Uh oh!

modular-magician commented Apr 8, 2025

Tests analytics

Uh oh!

modular-magician commented Apr 8, 2025

Diff report

Uh oh!

modular-magician commented Apr 8, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 8, 2025

Uh oh!

modular-magician commented Apr 8, 2025

Diff report

Uh oh!

modular-magician commented Apr 8, 2025

Tests analytics

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

melinath left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Apr 16, 2025

Diff report

Uh oh!

modular-magician commented Apr 16, 2025

Diff report

Uh oh!

modular-magician commented Apr 16, 2025

Tests analytics

Uh oh!

modular-magician commented Apr 16, 2025

Tests analytics

Uh oh!

modular-magician commented Apr 17, 2025

Diff report

Uh oh!

modular-magician commented Apr 17, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 17, 2025

Uh oh!

modular-magician commented Apr 17, 2025

Diff report

Uh oh!

modular-magician commented Apr 17, 2025

Tests analytics

Uh oh!

github-actions bot commented Apr 21, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Apr 23, 2025

Diff report

Uh oh!

modular-magician commented Apr 23, 2025

Tests analytics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

melinath left a comment •

edited

Loading