location attribute incorrectly marked as optional for cross-cloud interconnect

[abhijeetkjha-google]

compute: marked `location` field as required in `google_compute_interconnect` resource

On the resource 'google_compute_interconnect', the attribute 'location' is incorrectly marked as optional, even for cross-cloud interconnect. It needs to be required.

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_interconnect
location - (Optional) URL of the InterconnectLocation object that represents where this connection is to be provisioned. Specifies the location inside Google's Networks, should not be passed in case of cross-cloud interconnect.

It should be marked as a required field, the customer has to provide a location for all interconnects regardless of whether it's cross cloud or not.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[abhijeetkjha-google]

Hi @BBBmau , Could you please take a look at this PR when you have a moment? Thanks!

[BBBmau]

thanks for catching this! Confirming the issue from testing this the example configuration but without the field set