pubsub_lite_reservation demo fwprovider conversion by NickElliot · Pull Request #13672 · GoogleCloudPlatform/magic-modules

NickElliot · 2025-04-14T21:17:13Z

Release Note Template for Downstream PRs (will be copied)

…k' into demoresconv

modular-magician · 2025-04-14T21:28:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 430 insertions(+))
google-beta provider: Diff ( 3 files changed, 430 insertions(+))

modular-magician · 2025-04-14T21:31:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 430 insertions(+))
google-beta provider: Diff ( 3 files changed, 430 insertions(+))

modular-magician · 2025-04-14T21:32:37Z

Tests analytics

Total tests: 1
Passed tests: 0
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccResourceFWPubsubLiteReservation_basic
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-04-14T21:34:27Z

Tests analytics

Total tests: 1
Passed tests: 0
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccResourceFWPubsubLiteReservation_basic
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-04-16T21:09:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 448 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 4 files changed, 448 insertions(+), 12 deletions(-))

modular-magician · 2025-04-16T21:28:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 448 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 4 files changed, 448 insertions(+), 12 deletions(-))

modular-magician · 2025-04-16T23:11:02Z

Tests analytics

Total tests: 4790
Passed tests: 4241
Skipped tests: 446
Affected tests: 103

Click here to see the affected service packages

Action taken

Found 103 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-16T23:29:28Z

Tests analytics

Total tests: 4790
Passed tests: 4238
Skipped tests: 446
Affected tests: 106

Click here to see the affected service packages

Action taken

Found 106 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-17T02:42:18Z

🟢 Tests passed during RECORDING mode:
TestAccAlloydbInstance_createInstanceWithPscInterfaceConfigs [Debug log]
TestAccAlloydbInstance_update [Debug log]
TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs [Debug log]
TestAccBigqueryAnalyticsHubListingSubscription_bigqueryAnalyticshubListingSubscriptionBasicExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekExample [Debug log]
TestAccCloudRunService_cloudRunServiceSqlExample [Debug log]
TestAccCloudRunV2Job_cloudrunv2JobSqlExample [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccDataSourceGoogleSQLCaCerts_basic [Debug log]
TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic [Debug log]
TestAccDataSourceSqlDatabaseInstance_basic [Debug log]
TestAccDataSourceSqlDatabaseInstances_basic [Debug log]
TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter [Debug log]
TestAccDataSourceSqlDatabaseInstances_regionFilter [Debug log]
TestAccDataSourceSqlDatabaseInstances_tierFilter [Debug log]
TestAccDataSourceSqlDatabase_basic [Debug log]
TestAccDataSourceSqlDatabases_basic [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingMysqlExample [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingPostgresExample [Debug log]
TestAccDatastreamConnectionProfile_sshKey_update [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Debug log]
TestAccFirestoreIndex_firestoreIndexDatastoreModeExample [Debug log]
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample [Debug log]
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample [Debug log]
TestAccSQLDatabaseInstance_DefaultEdition [Debug log]
TestAccSQLDatabaseInstance_DenyMaintenancePeriod [Debug log]
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSQLDatabase_sqlDatabaseBasicExample [Debug log]
TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample [Debug log]
TestAccSqlClientCert_mysql [Debug log]
TestAccSqlClientCert_postgres [Debug log]
TestAccSqlDatabaseInstance_BackupRetention [Debug log]
TestAccSqlDatabaseInstance_Edition [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Timezone [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basicSecondGen [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_diskspecs [Debug log]
TestAccSqlDatabaseInstance_encryptionKey [Debug log]
TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion [Debug log]
TestAccSqlDatabaseInstance_highAvailability [Debug log]
TestAccSqlDatabaseInstance_insights [Debug log]
TestAccSqlDatabaseInstance_maintenance [Debug log]
TestAccSqlDatabaseInstance_maintenanceVersion [Debug log]
TestAccSqlDatabaseInstance_maintenance_update_track_week5 [Debug log]
TestAccSqlDatabaseInstance_multipleOperations [Debug log]
TestAccSqlDatabaseInstance_replica [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settingsDowngrade [Debug log]
TestAccSqlDatabaseInstance_settings_basic [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_secondary [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_slave [Debug log]
TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample [Debug log]
TestAccSqlDatabaseInstance_updateDifferentFlagOrder [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_useCasBasedServerCa [Debug log]
TestAccSqlDatabaseInstance_useInternalCaByDefault [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withPscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withoutPscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabase_basic [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]
TestAccSqlDatabase_update [Debug log]
TestAccSqlUser_password_wo [Debug log]
TestAccSqlUser_postgres [Debug log]
TestAccSqlUser_postgresAbandon [Debug log]
TestAccSqlUser_postgresIAM [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreDocumentProcessingConfigLayoutExample [Error message] [Debug log]
TestAccResourceFWPubsubLiteReservation_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-17T03:00:36Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccAlloydbInstance_createInstanceWithPscInterfaceConfigs [Debug log]
TestAccAlloydbInstance_update [Debug log]
TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs [Debug log]
TestAccBigqueryAnalyticsHubListingSubscription_bigqueryAnalyticshubListingSubscriptionBasicExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekExample [Debug log]
TestAccCloudRunService_cloudRunServiceSqlExample [Debug log]
TestAccCloudRunV2Job_cloudrunv2JobSqlExample [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccDataSourceGoogleSQLCaCerts_basic [Debug log]
TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic [Debug log]
TestAccDataSourceSqlDatabaseInstance_basic [Debug log]
TestAccDataSourceSqlDatabaseInstances_basic [Debug log]
TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter [Debug log]
TestAccDataSourceSqlDatabaseInstances_regionFilter [Debug log]
TestAccDataSourceSqlDatabaseInstances_tierFilter [Debug log]
TestAccDataSourceSqlDatabase_basic [Debug log]
TestAccDataSourceSqlDatabases_basic [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingMysqlExample [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingPostgresExample [Debug log]
TestAccDatastreamConnectionProfile_sshKey_update [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Debug log]
TestAccFirestoreIndex_firestoreIndexDatastoreModeExample [Debug log]
TestAccIdentityPlatformConfig_identityPlatformConfigWithFalseValuesExample [Debug log]
TestAccLoggingFolderSettings_update [Debug log]
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample [Debug log]
TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample [Debug log]
TestAccSQLDatabaseInstance_DefaultEdition [Debug log]
TestAccSQLDatabaseInstance_DenyMaintenancePeriod [Debug log]
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSQLDatabase_sqlDatabaseBasicExample [Debug log]
TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample [Debug log]
TestAccSqlClientCert_mysql [Debug log]
TestAccSqlClientCert_postgres [Debug log]
TestAccSqlDatabaseInstance_BackupRetention [Debug log]
TestAccSqlDatabaseInstance_Edition [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Timezone [Debug log]
TestAccSqlDatabaseInstance_activationPolicy [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basicSecondGen [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_diskspecs [Debug log]
TestAccSqlDatabaseInstance_encryptionKey [Debug log]
TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion [Debug log]
TestAccSqlDatabaseInstance_highAvailability [Debug log]
TestAccSqlDatabaseInstance_insights [Debug log]
TestAccSqlDatabaseInstance_maintenance [Debug log]
TestAccSqlDatabaseInstance_maintenanceVersion [Debug log]
TestAccSqlDatabaseInstance_multipleOperations [Debug log]
TestAccSqlDatabaseInstance_replica [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settingsDowngrade [Debug log]
TestAccSqlDatabaseInstance_settings_basic [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_secondary [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_slave [Debug log]
TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_useCasBasedServerCa [Debug log]
TestAccSqlDatabaseInstance_useInternalCaByDefault [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withPscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_withoutPscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica [Debug log]
TestAccSqlDatabase_basic [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]
TestAccSqlDatabase_update [Debug log]
TestAccSqlUser_password_wo [Debug log]
TestAccSqlUser_postgres [Debug log]
TestAccSqlUser_postgresAbandon [Debug log]
TestAccSqlUser_postgresIAM [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreDocumentProcessingConfigLayoutExample [Error message] [Debug log]
TestAccResourceFWPubsubLiteReservation_basic [Error message] [Debug log]
TestAccSqlDatabaseInstance_maintenance_update_track_week5 [Error message] [Debug log]
TestAccSqlDatabaseInstance_updateDifferentFlagOrder [Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-17T17:09:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 448 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 4 files changed, 448 insertions(+), 12 deletions(-))

modular-magician · 2025-04-17T19:11:47Z

Tests analytics

Total tests: 4790
Passed tests: 4338
Skipped tests: 446
Affected tests: 6

Click here to see the affected service packages

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-17T19:33:41Z

🟢 Tests passed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreDocumentProcessingConfigLayoutExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

c2thorn · 2025-04-17T19:37:42Z

+
+	// Put data in model
+	data.Id = types.StringValue(fmt.Sprintf("projects/%s/locations/%s/reservations/%s", data.Project.ValueString(), data.Region.ValueString(), data.Name.ValueString()))
+	data.ThroughputCapacity = types.Int64Value(res["throughputCapacity"].(int64))


This is the only field that really needs to be read, so we don't need to call Read or any shared function right?

yeah, I could add the read call for if we want it because of it being what the template will do, but its unneeded for this

c2thorn · 2025-04-17T19:38:08Z

+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccResourceFWPubsubLiteReservation_basic(context),


update step?

modular-magician · 2025-04-18T20:55:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 465 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 4 files changed, 465 insertions(+), 12 deletions(-))

modular-magician · 2025-04-18T20:59:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 465 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 4 files changed, 465 insertions(+), 12 deletions(-))

modular-magician · 2025-04-18T22:56:34Z

Tests analytics

Total tests: 4790
Passed tests: 4329
Skipped tests: 446
Affected tests: 15

Click here to see the affected service packages

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-18T23:05:10Z

Tests analytics

Total tests: 4790
Passed tests: 4329
Skipped tests: 446
Affected tests: 15

Click here to see the affected service packages

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-04-18T23:18:19Z

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_backendServiceCacheBypassCacheOnRequestHeadersExample [Debug log]
TestAccComputeBackendService_backendServiceCacheExample [Debug log]
TestAccComputeBackendService_backendServiceCacheIncludeHttpHeadersExample [Debug log]
TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample [Debug log]
TestAccComputeBackendService_backendServiceCacheSimpleExample [Debug log]
TestAccComputeBackendService_withCdnPolicy [Debug log]
TestAccComputeBackendService_withCompressionMode [Debug log]
TestAccComputeBackendService_withLogConfig [Debug log]
TestAccDNSManagedZone_privateForwardingUpdate [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreDocumentProcessingConfigLayoutExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-18T23:29:52Z

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_backendServiceCacheBypassCacheOnRequestHeadersExample [Debug log]
TestAccComputeBackendService_backendServiceCacheExample [Debug log]
TestAccComputeBackendService_backendServiceCacheIncludeHttpHeadersExample [Debug log]
TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample [Debug log]
TestAccComputeBackendService_backendServiceCacheSimpleExample [Debug log]
TestAccComputeBackendService_withCdnPolicy [Debug log]
TestAccComputeBackendService_withCompressionMode [Debug log]
TestAccComputeBackendService_withLogConfig [Debug log]
TestAccDNSManagedZone_privateForwardingUpdate [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreDocumentProcessingConfigLayoutExample [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

c2thorn

i'm not seeing TestAccResourceFWPubsubLiteReservation_basic in the passing list of tests, but it didn't show in the failing ones?

NickElliot · 2025-04-21T20:32:42Z

if you go into the debug log for all tests it appears to have passed in recording? I'm not sure why it isnt there on this end

NickElliot added 12 commits April 3, 2025 14:38

demo data source

570f191

initial

8cd40b8

cleanup + transport functions

f4e201b

build issue

52847d7

build issue

0c0637a

full build

e431331

refactor type switches

8871500

gofmt

590bfd2

remove data source in seperate PR

ab52a7a

readding resource

c5aa21f

pubsub resource

073c1d1

test

d7926b6

NickElliot marked this pull request as draft April 14, 2025 21:17

NickElliot added 2 commits April 14, 2025 14:19

Merge remote-tracking branch 'upstream/FEATURE-BRANCH-plugin-framewor…

2c56135

…k' into demoresconv

gofmt

d988c05

NickElliot added 2 commits April 16, 2025 13:37

fixed http/tests

8a034f1

Merge branch 'FEATURE-BRANCH-plugin-framework' into demoresconv

09705d1

fmt

a564555

create url

e91fce5

NickElliot requested a review from c2thorn April 17, 2025 16:57

NickElliot marked this pull request as ready for review April 17, 2025 16:57

c2thorn reviewed Apr 17, 2025

View reviewed changes

NickElliot added 2 commits April 18, 2025 13:44

upgrade

3a3a4c9

fmt

517e0b6

c2thorn approved these changes Apr 21, 2025

View reviewed changes

NickElliot merged commit b5d9529 into GoogleCloudPlatform:FEATURE-BRANCH-plugin-framework Apr 21, 2025
19 of 20 checks passed

Conversation

NickElliot commented Apr 14, 2025

Uh oh!

modular-magician commented Apr 14, 2025

Diff report

Uh oh!

modular-magician commented Apr 14, 2025

Diff report

Uh oh!

modular-magician commented Apr 14, 2025

Tests analytics

Uh oh!

modular-magician commented Apr 14, 2025

Tests analytics

Uh oh!

modular-magician commented Apr 16, 2025

Diff report

Uh oh!

modular-magician commented Apr 16, 2025

Diff report

Uh oh!

modular-magician commented Apr 16, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 16, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 17, 2025

Uh oh!

modular-magician commented Apr 17, 2025

Uh oh!

modular-magician commented Apr 17, 2025

Diff report

Uh oh!

modular-magician commented Apr 17, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 17, 2025

Uh oh!

c2thorn Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

NickElliot Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

c2thorn Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Apr 18, 2025

Diff report

Uh oh!

modular-magician commented Apr 18, 2025

Diff report

Uh oh!

modular-magician commented Apr 18, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 18, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 18, 2025

Uh oh!

modular-magician commented Apr 18, 2025

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

NickElliot commented Apr 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone