Skip to content

Remove bad ExpectError from data. google_kms_crypto_key_latest_versio…#13757

Merged
rileykarson merged 1 commit intomainfrom
rileykarson-patch-8
Apr 23, 2025
Merged

Remove bad ExpectError from data. google_kms_crypto_key_latest_versio…#13757
rileykarson merged 1 commit intomainfrom
rileykarson-patch-8

Conversation

@rileykarson
Copy link
Copy Markdown
Member

@rileykarson rileykarson commented Apr 23, 2025

Fixes hashicorp/terraform-provider-google#20110

I think the contributor misunderstood when to use ExpectError? We're referencing a bootstrapped key that has a version in it.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 43
Passed tests: 38
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleKmsCryptoKeyLatestVersion_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleKmsCryptoKeyLatestVersion_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@rileykarson
Copy link
Copy Markdown
Member Author

VCR had a destroyed key as latest, but nightlies have an enabled one. Added a new VCR key.

/gcbrun

@rileykarson
Copy link
Copy Markdown
Member Author

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 43
Passed tests: 38
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleKmsCryptoKeyLatestVersion_basic

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 43
Passed tests: 38
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleKmsCryptoKeyLatestVersion_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleKmsCryptoKeyLatestVersion_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleKmsCryptoKeyLatestVersion_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@rileykarson rileykarson requested review from a team and ScottSuarez and removed request for a team April 23, 2025 22:02
@rileykarson rileykarson added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit fe4c3ff Apr 23, 2025
21 of 22 checks passed
@rileykarson rileykarson deleted the rileykarson-patch-8 branch April 23, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDataSourceGoogleKmsCryptoKeyLatestVersion_basic

3 participants