Remove bad ExpectError from data. google_kms_crypto_key_latest_versio…#13757
Merged
rileykarson merged 1 commit intomainfrom Apr 23, 2025
Merged
Remove bad ExpectError from data. google_kms_crypto_key_latest_versio…#13757rileykarson merged 1 commit intomainfrom
rileykarson merged 1 commit intomainfrom
Conversation
Collaborator
Collaborator
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Member
Author
|
VCR had a destroyed key as latest, but nightlies have an enabled one. Added a new VCR key. /gcbrun |
Member
Author
|
/gcbrun |
Collaborator
1 similar comment
Collaborator
Collaborator
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Collaborator
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
Collaborator
ScottSuarez
approved these changes
Apr 23, 2025
NandiniAgrawal15
pushed a commit
to NandiniAgrawal15/magic-modules
that referenced
this pull request
Apr 26, 2025
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
May 13, 2025
jingqizz
pushed a commit
to jingqizz/magic-modules
that referenced
this pull request
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#20110
I think the contributor misunderstood when to use ExpectError? We're referencing a bootstrapped key that has a version in it.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.