Skip to content

Improve documentation for google_compute_backend_bucket.cdn_policy#13765

Merged
slevenick merged 1 commit intoGoogleCloudPlatform:mainfrom
andyyaldoo:fix-docs
Apr 24, 2025
Merged

Improve documentation for google_compute_backend_bucket.cdn_policy#13765
slevenick merged 1 commit intoGoogleCloudPlatform:mainfrom
andyyaldoo:fix-docs

Conversation

@andyyaldoo
Copy link
Copy Markdown
Contributor

@andyyaldoo andyyaldoo commented Apr 24, 2025

State that default_ttl, client_ttl, max_ttl should be omitted when cache_mode is set to USE_ORIGIN_HEADERS.

Fixes hashicorp/terraform-provider-google#22496

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Improve documentation for `google_compute_backend_bucket.cdn_policy`

State that `default_ttl`, `client_ttl`, `max_ttl` should be omitted when
`cache_mode` is set to `USE_ORIGIN_HEADERS`
@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 24, 2025
@andyyaldoo andyyaldoo marked this pull request as ready for review April 24, 2025 13:30
@github-actions github-actions bot requested a review from slevenick April 24, 2025 13:31
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 24, 2025
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 18 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 2 files changed, 18 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1173
Passed tests: 1089
Skipped tests: 84
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve documentation for google_compute_backend_bucket.cdn_policy

3 participants