Fix handling of 405 merge in progress#13770
Fix handling of 405 merge in progress#13770ScottSuarez merged 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
| } | ||
|
|
||
| err := utils.RequestCall(url, "GET", gh.token, &commit, nil) | ||
| err := utils.RequestCallSilent(url, "GET", gh.token, &commit, nil) |
There was a problem hiding this comment.
Why does this need to be silent? We generally want to log all of these requests for debugging purposes.
There was a problem hiding this comment.
Thomas removed the printing of the result for POST requests because this API outputs a lot. I am pretty sure we are listing a lot of commits so I can understand.
I added the printing of the POST back but thomas was saying that this caused the test output to be too long. I don't think we should be testing this in a presubmit anyways but this is just to unblock adding back the POST result to console
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
melinath
left a comment
melinath
left a comment
There was a problem hiding this comment.
I would somewhat prefer that we fix the unit test to not call the API rather than remove logging, and I have a slight concern that this extra method will live longer than we want it to - but I don't currently feel strongly enough to block merging this.
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Okay, I changed the testcase instead. Note that this will mean the delete branch operation might be a bit noisy in cloud build. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
ffdfe9e
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
3 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.