Adding desired_auto_created_endpoints Virtual field to Memorystore instance by NA2047 · Pull Request #13819 · GoogleCloudPlatform/magic-modules

NA2047 · 2025-04-29T22:04:05Z

Release Note Template for Downstream PRs (will be copied)

memorystore: added field `desired_auto_created_endpoints` for `google_memorystore_instance` resource

github-actions · 2025-04-29T22:05:08Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-04-29T22:16:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 125 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 6 files changed, 125 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-04-29T22:19:16Z

Tests analytics

Total tests: 19
Passed tests: 3
Skipped tests: 0
Affected tests: 16

Click here to see the affected service packages

memorystore

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstanceDatasourceConfig

TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserAndAutoCreatedEndpointsExample

TestAccMemorystoreInstance_automatedBackupConfig

TestAccMemorystoreInstance_memorystoreInstanceBasicExample

TestAccMemorystoreInstance_memorystoreInstanceFullExample

TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample

TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample

TestAccMemorystoreInstance_switchoverAndDetachSecondary

TestAccMemorystoreInstance_updateDeletionProtection

TestAccMemorystoreInstance_updateEngineVersion

TestAccMemorystoreInstance_updateInstanceEndpoints

TestAccMemorystoreInstance_updateNodeType

TestAccMemorystoreInstance_updatePersistence

TestAccMemorystoreInstance_updateRedisConfigs

TestAccMemorystoreInstance_updateReplicaCount

TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

modular-magician · 2025-04-29T23:14:59Z

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstanceDesiredUserCreatedEndpoints_memorystoreInstanceDesiredUserAndAutoCreatedEndpointsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDatasourceConfig [Error message] [Debug log]
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Error message] [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…hared and repl count on tests

modular-magician · 2025-04-30T23:02:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 145 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 7 files changed, 144 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-04-30T23:03:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 144 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 7 files changed, 144 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-04-30T23:05:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 144 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 7 files changed, 144 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-04-30T23:05:22Z

Tests analytics

Total tests: 19
Passed tests: 4
Skipped tests: 0
Affected tests: 15

Click here to see the affected service packages

memorystore

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstanceDatasourceConfig

TestAccMemorystoreInstance_automatedBackupConfig

TestAccMemorystoreInstance_memorystoreInstanceBasicExample

TestAccMemorystoreInstance_memorystoreInstanceFullExample

TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample

TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample

TestAccMemorystoreInstance_switchoverAndDetachSecondary

TestAccMemorystoreInstance_updateDeletionProtection

TestAccMemorystoreInstance_updateEngineVersion

TestAccMemorystoreInstance_updateInstanceEndpoints

TestAccMemorystoreInstance_updateNodeType

TestAccMemorystoreInstance_updatePersistence

TestAccMemorystoreInstance_updateRedisConfigs

TestAccMemorystoreInstance_updateReplicaCount

TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

modular-magician · 2025-04-30T23:06:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 144 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 7 files changed, 144 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-04-30T23:06:44Z

Tests analytics

Total tests: 19
Passed tests: 4
Skipped tests: 0
Affected tests: 15

Click here to see the affected service packages

memorystore

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstanceDatasourceConfig

TestAccMemorystoreInstance_automatedBackupConfig

TestAccMemorystoreInstance_memorystoreInstanceBasicExample

TestAccMemorystoreInstance_memorystoreInstanceFullExample

TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample

TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample

TestAccMemorystoreInstance_switchoverAndDetachSecondary

TestAccMemorystoreInstance_updateDeletionProtection

TestAccMemorystoreInstance_updateEngineVersion

TestAccMemorystoreInstance_updateInstanceEndpoints

TestAccMemorystoreInstance_updateNodeType

TestAccMemorystoreInstance_updatePersistence

TestAccMemorystoreInstance_updateRedisConfigs

TestAccMemorystoreInstance_updateReplicaCount

TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

modular-magician · 2025-04-30T23:08:03Z

Tests analytics

Total tests: 19
Passed tests: 4
Skipped tests: 0
Affected tests: 15

Click here to see the affected service packages

memorystore

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstanceDatasourceConfig

TestAccMemorystoreInstance_automatedBackupConfig

TestAccMemorystoreInstance_memorystoreInstanceBasicExample

TestAccMemorystoreInstance_memorystoreInstanceFullExample

TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample

TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample

TestAccMemorystoreInstance_switchoverAndDetachSecondary

TestAccMemorystoreInstance_updateDeletionProtection

TestAccMemorystoreInstance_updateEngineVersion

TestAccMemorystoreInstance_updateInstanceEndpoints

TestAccMemorystoreInstance_updateNodeType

TestAccMemorystoreInstance_updatePersistence

TestAccMemorystoreInstance_updateRedisConfigs

TestAccMemorystoreInstance_updateReplicaCount

TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

modular-magician · 2025-04-30T23:09:34Z

Tests analytics

Total tests: 19
Passed tests: 4
Skipped tests: 0
Affected tests: 15

Click here to see the affected service packages

memorystore

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstanceDatasourceConfig

TestAccMemorystoreInstance_automatedBackupConfig

TestAccMemorystoreInstance_memorystoreInstanceBasicExample

TestAccMemorystoreInstance_memorystoreInstanceFullExample

TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample

TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample

TestAccMemorystoreInstance_switchoverAndDetachSecondary

TestAccMemorystoreInstance_updateDeletionProtection

TestAccMemorystoreInstance_updateEngineVersion

TestAccMemorystoreInstance_updateInstanceEndpoints

TestAccMemorystoreInstance_updateNodeType

TestAccMemorystoreInstance_updatePersistence

TestAccMemorystoreInstance_updateRedisConfigs

TestAccMemorystoreInstance_updateReplicaCount

TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

modular-magician · 2025-04-30T23:56:08Z

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDatasourceConfig [Error message] [Debug log]
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Error message] [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-30T23:58:57Z

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDatasourceConfig [Error message] [Debug log]
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Error message] [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-04-30T23:59:43Z

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDatasourceConfig [Error message] [Debug log]
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Error message] [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-01T00:06:58Z

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDatasourceConfig [Error message] [Debug log]
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Error message] [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-01T17:05:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 148 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 8 files changed, 148 insertions(+), 29 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-05-01T17:08:47Z

Tests analytics

Total tests: 19
Passed tests: 4
Skipped tests: 0
Affected tests: 15

Click here to see the affected service packages

memorystore

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstanceDatasourceConfig

TestAccMemorystoreInstance_automatedBackupConfig

TestAccMemorystoreInstance_memorystoreInstanceBasicExample

TestAccMemorystoreInstance_memorystoreInstanceFullExample

TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample

TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample

TestAccMemorystoreInstance_switchoverAndDetachSecondary

TestAccMemorystoreInstance_updateDeletionProtection

TestAccMemorystoreInstance_updateEngineVersion

TestAccMemorystoreInstance_updateInstanceEndpoints

TestAccMemorystoreInstance_updateNodeType

TestAccMemorystoreInstance_updatePersistence

TestAccMemorystoreInstance_updateRedisConfigs

TestAccMemorystoreInstance_updateReplicaCount

TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

modular-magician · 2025-05-01T18:02:31Z

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstanceDatasourceConfig [Error message] [Debug log]
TestAccMemorystoreInstance_automatedBackupConfig [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample [Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Error message] [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Error message] [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Error message] [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]
TestAccMemorystoreInstance_updateNodeType [Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence [Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-06T22:13:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 278 insertions(+), 118 deletions(-))
google-beta provider: Diff ( 8 files changed, 278 insertions(+), 118 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 59 insertions(+), 22 deletions(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-05-06T22:15:54Z

Tests analytics

Total tests: 20
Passed tests: 5
Skipped tests: 0
Affected tests: 15

Click here to see the affected service packages

memorystore

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstance_automatedBackupConfig

TestAccMemorystoreInstance_deprecatedDesiredPscAutoConnections

TestAccMemorystoreInstance_memorystoreInstanceBasicExample

TestAccMemorystoreInstance_memorystoreInstanceFullExample

TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample

TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample

TestAccMemorystoreInstance_switchoverAndDetachSecondary

TestAccMemorystoreInstance_updateDeletionProtection

TestAccMemorystoreInstance_updateEngineVersion

TestAccMemorystoreInstance_updateInstanceEndpoints

TestAccMemorystoreInstance_updateNodeType

TestAccMemorystoreInstance_updatePersistence

TestAccMemorystoreInstance_updateRedisConfigs

TestAccMemorystoreInstance_updateReplicaCount

TestAccMemorystoreInstance_updateShardCount

Get to know how VCR tests work

modular-magician · 2025-05-06T23:11:51Z

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_automatedBackupConfig [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceSecondaryInstanceExample [Debug log]
TestAccMemorystoreInstance_switchoverAndDetachSecondary [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection [Debug log]
TestAccMemorystoreInstance_updateEngineVersion [Debug log]
TestAccMemorystoreInstance_updateInstanceEndpoints [Debug log]
TestAccMemorystoreInstance_updateNodeType [Debug log]
TestAccMemorystoreInstance_updatePersistence [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs [Debug log]
TestAccMemorystoreInstance_updateReplicaCount [Debug log]
TestAccMemorystoreInstance_updateShardCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_deprecatedDesiredPscAutoConnections [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…_auto_connections is set

modular-magician · 2025-05-07T20:11:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 282 insertions(+), 117 deletions(-))
google-beta provider: Diff ( 8 files changed, 282 insertions(+), 117 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+), 22 deletions(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-05-07T20:14:35Z

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMemorystoreInstance_deprecatedDesiredPscAutoConnections

Get to know how VCR tests work

modular-magician · 2025-05-07T20:41:26Z

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_deprecatedDesiredPscAutoConnections [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-05-09T22:28:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 284 insertions(+), 119 deletions(-))
google-beta provider: Diff ( 8 files changed, 284 insertions(+), 119 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+), 22 deletions(-))
Open in Cloud Shell: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

google_memorystore_instance
- Expected Document Path: /website/docs/r/memorystore_instance.html.markdown
- Fields: [desired_auto_created_endpoints.network desired_auto_created_endpoints.project_id]

modular-magician · 2025-05-09T22:31:40Z

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

memorystore

🟢 All tests passed!

View the build log

github-actions · 2025-05-12T09:43:26Z

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-05-14T09:43:12Z

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

NickElliot

some questions and potentially a needed change:

could you re-add a test that uses desired_psc_auto_connections for the time being, as it has not been totally removed yet
is it possible to do the in-place upgrade to desired_auto_created_endpoints from desired_psc_auto_connections? If so could you add an upgrade test that includes this process (i.e. step 1 use deprecated field, step 2 swap to new field)

NA2047 · 2025-05-16T20:38:06Z

some questions and potentially a needed change:

could you re-add a test that uses desired_psc_auto_connections for the time being, as it has not been totally removed yet

is it possible to do the in-place upgrade to desired_auto_created_endpoints from desired_psc_auto_connections? If so could you add an upgrade test that includes this process (i.e. step 1 use deprecated field, step 2 swap to new field)

Hey @NickElliot

I have added the following to cover this TestAccMemorystoreInstance_deprecatedDesiredPscAutoConnections
These are both set to immutable so it will recreate this instance, If you would still like me to write a test for this, please let me know :)

NickElliot

ah, sorry missed that, LGTM!

…stance (GoogleCloudPlatform#13819)

NA2047 added 2 commits April 25, 2025 11:15

WIP

740d071

First commit

a06615c

NA2047 marked this pull request as draft April 29, 2025 22:04

github-actions bot requested a review from NickElliot April 29, 2025 22:05

modular-magician added the service/memorystore label Apr 29, 2025

NA2047 force-pushed the MemorystoreEndpoints_test branch 2 times, most recently from 3725e21 to 52d1bc7 Compare April 30, 2025 22:53

Updating tests with new desired_auto_created_endpoints and reducing s…

f1965ed

…hared and repl count on tests

NA2047 force-pushed the MemorystoreEndpoints_test branch from 52d1bc7 to f1965ed Compare April 30, 2025 22:54

Updating tests

34ca62d

Updating deprecation

9483ce3

Fixed desired_auto_created_endpoints getting updated when desired_psc…

0f1a2bc

…_auto_connections is set

NA2047 marked this pull request as ready for review May 7, 2025 20:52

NA2047 requested a review from NickElliot May 7, 2025 20:52

Adding more clarity for desired_psc_auto_connections deprecation

d94cc31

NickElliot reviewed May 14, 2025

View reviewed changes

github-actions bot requested a review from NickElliot May 16, 2025 20:39

NickElliot approved these changes May 19, 2025

View reviewed changes

NickElliot added this pull request to the merge queue May 19, 2025

Merged via the queue into GoogleCloudPlatform:main with commit cbda0f1 May 19, 2025
24 checks passed

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025

Adding desired_auto_created_endpoints Virtual field to Memorystore in…

fecad24

…stance (GoogleCloudPlatform#13819)

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025

Adding desired_auto_created_endpoints Virtual field to Memorystore in…

7bb48cc

…stance (GoogleCloudPlatform#13819)

antoinedeschenes mentioned this pull request Jul 3, 2025

Valkey instance forces replacement terraform-google-modules/terraform-google-memorystore#304

Closed

jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025

Adding desired_auto_created_endpoints Virtual field to Memorystore in…

8c66bd6

…stance (GoogleCloudPlatform#13819)

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025

Adding desired_auto_created_endpoints Virtual field to Memorystore in…

192a90f

…stance (GoogleCloudPlatform#13819)

Conversation

NA2047 commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

modular-magician commented Apr 29, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Apr 29, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 29, 2025

Uh oh!

modular-magician commented Apr 30, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Apr 30, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Apr 30, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Apr 30, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 30, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented Apr 30, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 30, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 30, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 30, 2025

Uh oh!

modular-magician commented Apr 30, 2025

Uh oh!

modular-magician commented Apr 30, 2025

Uh oh!

modular-magician commented May 1, 2025

Uh oh!

modular-magician commented May 1, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 1, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 1, 2025

Uh oh!

modular-magician commented May 6, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 6, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 6, 2025

Uh oh!

modular-magician commented May 7, 2025

Diff report

Missing doc report (experimental)

Uh oh!

modular-magician commented May 7, 2025

NA2047 commented May 16, 2025 •

edited

Loading