Add terraform support for InterconnectGroup and InterconnectAttachmentGroup resources

[amanMahendroo]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_compute_interconnect_group`

`google_compute_interconnect_attachment_group`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3362 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 3362 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 304 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 214 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect_attachment_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_attachment_group" "primary" {
  attachments {
    attachment     = # value needed
    key_attachment = # value needed
  }
  configured {
    availability_sla {
      effective_sla = # value needed
      intended_sla_blockers {
        attachments        = # value needed
        blocker_type       = # value needed
        documentation_link = # value needed
        explanation        = # value needed
        metros             = # value needed
        regions            = # value needed
        zones              = # value needed
      }
    }
  }
  interconnect_group = # value needed
  logical_structure {
    regions {
      metros {
        facilities {
          facility = # value needed
          zones {
            attachment = # value needed
            zone       = # value needed
          }
        }
        metro = # value needed
      }
      region = # value needed
    }
  }
}

Resource: google_compute_interconnect_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_group" "primary" {
  configured {
    topology_capability {
      intended_capability_blockers {
        blocker_type       = # value needed
        documentation_link = # value needed
        explanation        = # value needed
        facilities         = # value needed
        interconnects      = # value needed
        metros             = # value needed
        zones              = # value needed
      }
      supported_sla = # value needed
    }
  }
  interconnects {
    interconnect     = # value needed
    key_interconnect = # value needed
  }
  physical_structure {
    metros {
      facilities {
        facility = # value needed
        zones {
          interconnects = # value needed
          zone          = # value needed
        }
      }
      metro = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1191
Passed tests: 1101
Skipped tests: 84
Affected tests: 6

Click here to see the affected service packages

• compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnectAttachmentGroup_basic
• TestAccComputeInterconnectAttachmentGroup_interconnectAttachmentGroupBasicExample
• TestAccComputeInterconnectAttachmentGroup_update
• TestAccComputeInterconnectGroup_basic
• TestAccComputeInterconnectGroup_interconnectGroupBasicExample
• TestAccComputeInterconnectGroup_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInterconnectAttachmentGroup_basic [Debug log]
TestAccComputeInterconnectAttachmentGroup_interconnectAttachmentGroupBasicExample [Debug log]
TestAccComputeInterconnectAttachmentGroup_update [Debug log]
TestAccComputeInterconnectGroup_basic [Debug log]
TestAccComputeInterconnectGroup_interconnectGroupBasicExample [Debug log]
TestAccComputeInterconnectGroup_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[amanMahendroo]

Hi @SirGitsalot ! Please help review this PR. Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3362 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 3362 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 304 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 214 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect_attachment_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_attachment_group" "primary" {
  attachments {
    attachment     = # value needed
    key_attachment = # value needed
  }
  configured {
    availability_sla {
      effective_sla = # value needed
      intended_sla_blockers {
        attachments        = # value needed
        blocker_type       = # value needed
        documentation_link = # value needed
        explanation        = # value needed
        metros             = # value needed
        regions            = # value needed
        zones              = # value needed
      }
    }
  }
  interconnect_group = # value needed
  logical_structure {
    regions {
      metros {
        facilities {
          facility = # value needed
          zones {
            attachment = # value needed
            zone       = # value needed
          }
        }
        metro = # value needed
      }
      region = # value needed
    }
  }
}

Resource: google_compute_interconnect_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_group" "primary" {
  configured {
    topology_capability {
      intended_capability_blockers {
        blocker_type       = # value needed
        documentation_link = # value needed
        explanation        = # value needed
        facilities         = # value needed
        interconnects      = # value needed
        metros             = # value needed
        zones              = # value needed
      }
      supported_sla = # value needed
    }
  }
  interconnects {
    interconnect     = # value needed
    key_interconnect = # value needed
  }
  physical_structure {
    metros {
      facilities {
        facility = # value needed
        zones {
          interconnects = # value needed
          zone          = # value needed
        }
      }
      metro = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1193
Passed tests: 1109
Skipped tests: 84
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[amanMahendroo]

Hi @SirGitsalot Looks like rebasing didn't fix the issue. PTAL

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3385 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 19 files changed, 3385 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 304 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 214 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect_attachment_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_attachment_group" "primary" {
  attachments {
    attachment = # value needed
    name       = # value needed
  }
  interconnect_group = # value needed
}

Resource: google_compute_interconnect_group (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_group" "primary" {
  interconnects {
    interconnect = # value needed
    name         = # value needed
  }
}

Multiple resources added

This PR adds multiple new resources: google_compute_interconnect_attachment_group, google_compute_interconnect_group. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1215
Passed tests: 1130
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
• TestAccComputeFirewallPolicyWithRules_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[SirGitsalot]

Ran the tests against the TeamCity upstreams to filter out the noise from all of the various passes on the PR and they passed. The two VCR failures are a known, unrelated issue.