Skip to content

Add workload identity pool namespace.#13920

Merged
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
stevenyang72:mwlid-namespace
May 20, 2025
Merged

Add workload identity pool namespace.#13920
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
stevenyang72:mwlid-namespace

Conversation

@stevenyang72
Copy link
Copy Markdown
Member

@stevenyang72 stevenyang72 commented May 13, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_iam_workload_identity_pool_namespace` (beta)

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 268 insertions(+))
google-beta provider: Diff ( 11 files changed, 1183 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 150 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

@stevenyang72
Copy link
Copy Markdown
Member Author

Hi @liminw @kenmccracken-google @duobianxing, please review the following generated documentation:


How to view the rendered documentation?

  1. Copy the raw markdown documentation pointed by the URL.
  2. Open Terraform documentation preview tool: https://registry.terraform.io/tools/doc-preview
  3. Paste the file content to the text box of the preview tool.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 23
Passed tests: 19
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • iambeta

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_full
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceBasicExample
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceFullExample
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_minimal

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMBetaWorkloadIdentityPoolNamespace_full [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceBasicExample [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceFullExample [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_minimal [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 268 insertions(+))
google-beta provider: Diff ( 11 files changed, 1183 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 150 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iambeta

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 209 insertions(+))
google-beta provider: Diff ( 11 files changed, 1183 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 150 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iambeta

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 200 insertions(+))
google-beta provider: Diff ( 11 files changed, 1183 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 150 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iambeta

🟢 All tests passed!

View the build log

@stevenyang72 stevenyang72 marked this pull request as ready for review May 14, 2025 21:12
@github-actions github-actions bot requested a review from zli82016 May 14, 2025 21:13
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@stevenyang72
Copy link
Copy Markdown
Member Author

stevenyang72 commented May 14, 2025

Hi @liminw @kenmccracken-google @duobianxing, please review the following generated documentation:


How to view the rendered documentation?

  1. Copy the raw markdown documentation pointed by the URL.
  2. Open Terraform documentation preview tool: https://registry.terraform.io/tools/doc-preview
  3. Paste the file content to the text box of the preview tool.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 195 insertions(+))
google-beta provider: Diff ( 8 files changed, 1143 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 140 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workload_identity_pool_namespace (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam_workload_identity_pool_namespace" "primary" {
  owner_service {
    principal_subject = # value needed
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 33
Passed tests: 31
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • iambeta

🟢 All tests passed!

View the build log

Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
Comment thread mmv1/templates/terraform/constants/iam_workload_identity_pool_namespace.go.tmpl Outdated
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
Comment thread mmv1/products/iambeta/WorkloadIdentityPoolNamespace.yaml Outdated
@github-actions github-actions bot requested a review from zli82016 May 20, 2025 17:35
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 194 insertions(+))
google-beta provider: Diff ( 7 files changed, 1099 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 33
Passed tests: 28
Skipped tests: 2
Affected tests: 3

Click here to see the affected service packages
  • iambeta

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_full
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceFullExample
  • TestAccIAMBetaWorkloadIdentityPoolNamespace_minimal

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMBetaWorkloadIdentityPoolNamespace_full [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_iamWorkloadIdentityPoolNamespaceFullExample [Debug log]
TestAccIAMBetaWorkloadIdentityPoolNamespace_minimal [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016
Copy link
Copy Markdown
Member

@liminw, do you mind reviewing the PR? Thanks.

@zli82016
Copy link
Copy Markdown
Member

I modified the release note to show the resource is only in beta.

@stevenyang72
Copy link
Copy Markdown
Member Author

I modified the release note to show the resource is only in beta.

Got it. Thanks @zli82016 !

@github-actions github-actions bot requested a review from zli82016 May 20, 2025 18:04
@zli82016 zli82016 added this pull request to the merge queue May 20, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 174fdc7 May 20, 2025
27 checks passed
@stevenyang72 stevenyang72 deleted the mwlid-namespace branch May 20, 2025 18:50
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants