Add workload identity pool namespace.#13920
Add workload identity pool namespace.#13920zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
ad05931 to
3336866
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iam_workload_identity_pool_namespace" "primary" {
owner_service {
principal_subject = # value needed
}
}
|
|
Hi @liminw @kenmccracken-google @duobianxing, please review the following generated documentation: How to view the rendered documentation?
|
Tests analyticsTotal tests: 23 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iam_workload_identity_pool_namespace" "primary" {
owner_service {
principal_subject = # value needed
}
}
|
Tests analyticsTotal tests: 23 Click here to see the affected service packages
🟢 All tests passed! View the build log |
3336866 to
851f34f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iam_workload_identity_pool_namespace" "primary" {
owner_service {
principal_subject = # value needed
}
}
Errors
|
Tests analyticsTotal tests: 23 Click here to see the affected service packages
🟢 All tests passed! View the build log |
851f34f to
2a20168
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iam_workload_identity_pool_namespace" "primary" {
owner_service {
principal_subject = # value needed
}
}
|
Tests analyticsTotal tests: 23 Click here to see the affected service packages
🟢 All tests passed! View the build log |
2a20168 to
a30b07e
Compare
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi @liminw @kenmccracken-google @duobianxing, please review the following generated documentation: How to view the rendered documentation?
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iam_workload_identity_pool_namespace" "primary" {
owner_service {
principal_subject = # value needed
}
}
|
Tests analyticsTotal tests: 33 Click here to see the affected service packages
🟢 All tests passed! View the build log |
a30b07e to
e73f4ff
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 33 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
|
@liminw, do you mind reviewing the PR? Thanks. |
|
I modified the release note to show the resource is only in beta. |
Got it. Thanks @zli82016 ! |
174fdc7
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.