Skip to content

added additionalPipelineOptions to google_dataflow_flex_template_job#13963

Merged
hao-nan-li merged 5 commits intoGoogleCloudPlatform:mainfrom
sharan-malyala:magic-modules-sharantej
May 20, 2025
Merged

added additionalPipelineOptions to google_dataflow_flex_template_job#13963
hao-nan-li merged 5 commits intoGoogleCloudPlatform:mainfrom
sharan-malyala:magic-modules-sharantej

Conversation

@sharan-malyala
Copy link
Copy Markdown
Contributor

@sharan-malyala sharan-malyala commented May 15, 2025

Fixes hashicorp/terraform-provider-google#22800

Added support for additionalPipelineOptions to google_dataflow_flex_template_job

dataflow: added `additional_pipeline_options` field to `google_dataflow_flex_template_job` resource

@github-actions github-actions bot requested a review from hao-nan-li May 15, 2025 10:41
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 3 files changed, 159 insertions(+), 16 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataflow_flex_template_job
    • Expected Document Path: /website/docs/r/dataflow_flex_template_job.html.markdown
    • Fields: [additional_pipeline_options]

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataflowFlexTemplateJob_withAdditionalPipelineOptions
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 4 files changed, 161 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataflowFlexTemplateJob_withAdditionalPipelineOptions
    🟢 All tests passed!

View the build log

@sharan-malyala
Copy link
Copy Markdown
Contributor Author

Followed the release-note format as per doc, but the changelog check is failing.

@github-actions github-actions bot requested a review from hao-nan-li May 16, 2025 18:37
@sharan-malyala
Copy link
Copy Markdown
Contributor Author

sharan-malyala commented May 16, 2025

Note - I get error when I run the tests in region other than us-central1. Error is similar to the one reported at - hashicorp/terraform-provider-google#18074

While the test is running, suddenly location is removed in the GET job API call.

Attaching the test run log for reference.
testWithOtherRegion.log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataflowFlexTemplateJob_withAdditionalPipelineOptions
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 4 files changed, 169 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataflowFlexTemplateJob_withAdditionalPipelineOptions
    🟢 All tests passed!

View the build log

@github-actions github-actions bot requested a review from hao-nan-li May 17, 2025 05:32
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataflowFlexTemplateJob_withAdditionalPipelineOptions
    🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li added this pull request to the merge queue May 20, 2025
Merged via the queue into GoogleCloudPlatform:main with commit d53c798 May 20, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additionalPipelineOptions to google_dataflow_flex_template_job resource

3 participants