Removed colab schedule post_create logic related to setting name

[melinath]

This is now duplicated logic, since setting name (and setting id based on the current project) now happens automatically.

Also removed extra functions that do the same thing as GetResourceNameFromSelfLink.

This is part of hashicorp/terraform-provider-google#22214

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 116 files changed, 119 insertions(+), 143 deletions(-))
google-beta provider: Diff ( 123 files changed, 126 insertions(+), 150 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 3 insertions(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 4949
Passed tests: 4482
Skipped tests: 460
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager
• TestAccCloudIdentityGroup
• TestAccCloudbuildWorkerPool_basic
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
• TestAccLoggingFolderSettings_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDiscoveryEngineChatEngine_discoveryengineChatEngineExistingDialogflowAgentExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

I believe the failing tests are unrelated to this change.

@modular-magician reassign-reviewer

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

The failing TGC tests may be related? I don't know why they would be, but there shouldn't be latent failures like we have for VCR there.

[melinath]

There were some unrelated issues with TGC tests last week. I think a re-run will clear it out.

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 116 files changed, 119 insertions(+), 143 deletions(-))
google-beta provider: Diff ( 123 files changed, 126 insertions(+), 150 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 3 insertions(+), 11 deletions(-))

[melinath]

Needed a merge of main because the downstreams job runs only on PR code - doesn't merge main in.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 116 files changed, 119 insertions(+), 143 deletions(-))
google-beta provider: Diff ( 123 files changed, 126 insertions(+), 150 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 3 insertions(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 4966
Passed tests: 4503
Skipped tests: 460
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAccessContextManager
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 4966
Passed tests: 4504
Skipped tests: 460
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

acceptance test failures are unrelated