Skip to content

Add Mirror Percent to request_mirror_policy in URLMAP#13974

Merged
SirGitsalot merged 4 commits intoGoogleCloudPlatform:mainfrom
Dawid212:mirrorpercent
May 21, 2025
Merged

Add Mirror Percent to request_mirror_policy in URLMAP#13974
SirGitsalot merged 4 commits intoGoogleCloudPlatform:mainfrom
Dawid212:mirrorpercent

Conversation

@Dawid212
Copy link
Copy Markdown
Contributor

@Dawid212 Dawid212 commented May 15, 2025

This PR Adds missing Mirror Percent to request_mirror_policy in URLMAP

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `mirrorPercent` field to `requestMirrorPolicy` in `defaultRouteAction`, `pathMatchers[].defaultRouteAction`, `pathMatchers[].pathRules[].routeAction`, and `pathMatchers[].routeRules[].routeAction` to `google_compute_url_map` resource (beta)

@github-actions github-actions bot requested a review from SirGitsalot May 15, 2025 19:54
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 15, 2025
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 691 insertions(+))
google-beta provider: Diff ( 4 files changed, 691 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 608 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_url_map (79 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    route_rules {
      route_action {
        request_mirror_policy {
          mirror_percent = # value needed
        }
      }
    }
  }
}

Copy link
Copy Markdown
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this field is only in the beta API so far, so there's some changes needed to limit it to TPG beta, otherwise LGTM. Thanks!

Comment thread mmv1/products/compute/UrlMap.yaml
Comment thread mmv1/products/compute/UrlMap.yaml
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1199
Passed tests: 1111
Skipped tests: 84
Affected tests: 4

Click here to see the affected service packages
  • compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeUrlMap_urlMapDefaultMirrorPercentExample
  • TestAccComputeUrlMap_urlMapPathMatcherDefaultMirrorPercentExample
  • TestAccComputeUrlMap_urlMapPathRuleMirrorPercentExample
  • TestAccComputeUrlMap_urlMapRouteRuleMirrorPercentExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeUrlMap_urlMapDefaultMirrorPercentExample [Debug log]
TestAccComputeUrlMap_urlMapPathMatcherDefaultMirrorPercentExample [Debug log]
TestAccComputeUrlMap_urlMapPathRuleMirrorPercentExample [Debug log]
TestAccComputeUrlMap_urlMapRouteRuleMirrorPercentExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from SirGitsalot May 19, 2025 08:11
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 19, 2025
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 19, 2025
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 280 insertions(+))
google-beta provider: Diff ( 4 files changed, 723 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_url_map (79 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    route_rules {
      route_action {
        request_mirror_policy {
          mirror_percent = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1200
Passed tests: 1117
Skipped tests: 83
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@SirGitsalot SirGitsalot added this pull request to the merge queue May 21, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 3c26542 May 21, 2025
27 checks passed
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants