Skip to content

Allow updates to the mtu property in the Network resource.#13995

Merged
roaks3 merged 1 commit intoGoogleCloudPlatform:mainfrom
AshwinGururagh:fix-mtu-not-patchable
May 21, 2025
Merged

Allow updates to the mtu property in the Network resource.#13995
roaks3 merged 1 commit intoGoogleCloudPlatform:mainfrom
AshwinGururagh:fix-mtu-not-patchable

Conversation

@AshwinGururagh
Copy link
Copy Markdown
Contributor

Currently using terraform to update the mtu property of the Network results in forcing the replacement of the Network resource.

This change marks the mtu property as mutable, and instead uses the PATCH API on the Network resource to update the mtu property of the network.

Fixes hashicorp/terraform-provider-google#22543

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: fixed VPC Network's MTU to be updatable without forcing a replacement of the Network resource.

@github-actions github-actions bot requested a review from BBBmau May 16, 2025 22:07
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Currently using terraform to update the mtu property of the Network
results in forcing the replacement of the Network resource.

This change marks the mtu property as mutable, and uses the PATCH
verb on the Network resource to update the mtu property of the
network.
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 146 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 146 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 146 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 146 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1196
Passed tests: 1111
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetwork_mtuAndUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeNetwork_mtuAndUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1196
Passed tests: 1111
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetwork_mtuAndUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeNetwork_mtuAndUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@rileykarson rileykarson requested review from roaks3 and removed request for BBBmau May 19, 2025 18:03
Copy link
Copy Markdown
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests LGTM

@roaks3 roaks3 added this pull request to the merge queue May 21, 2025
Merged via the queue into GoogleCloudPlatform:main with commit a6159af May 21, 2025
25 checks passed
@AshwinGururagh AshwinGururagh deleted the fix-mtu-not-patchable branch May 21, 2025 23:32
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing the MTU of a network force its replacement

3 participants