Skip to content

container: allow updating stack_type in place#14001

Merged
shuyama1 merged 2 commits intoGoogleCloudPlatform:mainfrom
DrFaust92:dual-stack-update
May 20, 2025
Merged

container: allow updating stack_type in place#14001
shuyama1 merged 2 commits intoGoogleCloudPlatform:mainfrom
DrFaust92:dual-stack-update

Conversation

@DrFaust92
Copy link
Copy Markdown
Contributor

@DrFaust92 DrFaust92 commented May 17, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added in-place update support for `ip_allocation_policy.stack_type` field in `google_container_cluster` resource

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@github-actions github-actions bot requested a review from shuyama1 May 17, 2025 02:09
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 17, 2025
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 20, 2025
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 34 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 34 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 235
Passed tests: 223
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_stackType_withDualStack

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_stackType_withDualStack [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@shuyama1 shuyama1 added this pull request to the merge queue May 20, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 8f0743c May 20, 2025
25 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025
)

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
)

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
)

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
)

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
)

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants