Skip to content

Skip private_service_connect in TestAccCloudbuildWorkerPool_basic#14007

Merged
shuyama1 merged 1 commit intoGoogleCloudPlatform:mainfrom
shuyama1:fix_TestAccCloudbuildWorkerPool_basic
May 19, 2025
Merged

Skip private_service_connect in TestAccCloudbuildWorkerPool_basic#14007
shuyama1 merged 1 commit intoGoogleCloudPlatform:mainfrom
shuyama1:fix_TestAccCloudbuildWorkerPool_basic

Conversation

@shuyama1
Copy link
Copy Markdown
Member

@shuyama1 shuyama1 commented May 18, 2025

Commented out private_service_connect from the test, since it's not available yet.

b/394920388#comment10

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 5 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 27
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • cloudbuild

🟢 All tests passed!

View the build log

@shuyama1 shuyama1 requested a review from zli82016 May 19, 2025 05:20
@shuyama1 shuyama1 added this pull request to the merge queue May 19, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 460d3de May 19, 2025
25 checks passed
@shuyama1 shuyama1 deleted the fix_TestAccCloudbuildWorkerPool_basic branch May 19, 2025 16:59
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants