Skip to content

fix flaky test TestAccComputeInstanceSettings_update#14008

Merged
shuyama1 merged 1 commit intomainfrom
shuyama1-patch-20
May 19, 2025
Merged

fix flaky test TestAccComputeInstanceSettings_update#14008
shuyama1 merged 1 commit intomainfrom
shuyama1-patch-20

Conversation

@shuyama1
Copy link
Copy Markdown
Member

@shuyama1 shuyama1 commented May 18, 2025

Use a different zone than the one specified in TestAccComputeInstanceSettings_instanceSettingsBasicExample to avoid conflicts, as this is a singleton resource.

fixes hashicorp/terraform-provider-google#16741

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1195
Passed tests: 1110
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceSettings_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceSettings_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@shuyama1 shuyama1 requested review from a team and rileykarson and removed request for a team May 19, 2025 05:21
@shuyama1 shuyama1 added this pull request to the merge queue May 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2025
@shuyama1 shuyama1 added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit f17e173 May 19, 2025
26 checks passed
@shuyama1 shuyama1 deleted the shuyama1-patch-20 branch May 19, 2025 20:57
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeInstanceSettings_update

3 participants