Skip to content

remove TestAccComputeHealthCheck_tcpAndSsl_shouldFail#14009

Merged
shuyama1 merged 1 commit intoGoogleCloudPlatform:mainfrom
shuyama1:fix_ComputeHealthCheck_unit
May 19, 2025
Merged

remove TestAccComputeHealthCheck_tcpAndSsl_shouldFail#14009
shuyama1 merged 1 commit intoGoogleCloudPlatform:mainfrom
shuyama1:fix_ComputeHealthCheck_unit

Conversation

@shuyama1
Copy link
Copy Markdown
Member

@shuyama1 shuyama1 commented May 18, 2025

The test started failing in beta after a conflicting field was introduced in #13608. While #13901 addressed these beta failures by updating the expected error message to include the new field, it caused the tests to fail in GA because the field is beta-only

Instead of fixing the tests in GA, I propose removing them for the following reasons:

  1. Limited value of the tests. The tests are narrowly focused on verifying that the provider errors out when two specific conflicting fields are set. It's basically testing the conflict_with behavior for only this particular pair of fields, while we don't apply the same validation to other conflicting field.
  2. High Maintenance Cost. These tests require updates whenever a new conflicting field is added

Fixes hashicorp/terraform-provider-google#22812

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 80 deletions(-))
google-beta provider: Diff ( 2 files changed, 80 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1193
Passed tests: 1111
Skipped tests: 82
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@shuyama1 shuyama1 requested a review from melinath May 19, 2025 05:23
Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@shuyama1 shuyama1 added this pull request to the merge queue May 19, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 8aaddd1 May 19, 2025
27 checks passed
@shuyama1 shuyama1 deleted the fix_ComputeHealthCheck_unit branch May 19, 2025 18:23
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeHealthCheck_tcpAndSsl_shouldFail

3 participants