feat: added google_bigquery_table data source

[ramonvermeulen]

Closes hashicorp/terraform-provider-google#22834

• First time doing a data source implementation

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Acceptance tests locally:

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/bigquery -v -run=TestAccDataSourceGoogleBigqueryTable_basic -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceGoogleBigqueryTable_basic
=== PAUSE TestAccDataSourceGoogleBigqueryTable_basic
=== CONT  TestAccDataSourceGoogleBigqueryTable_basic
--- PASS: TestAccDataSourceGoogleBigqueryTable_basic (12.87s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/bigquery 13.550s

Would like to get some thoughts on the schema property, since it has a reference to itself. E.g. when the type = RECORD it has a nested schema, following the google docs this has a max depth of 15.

https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#tableschema
https://cloud.google.com/bigquery/docs/nested-repeated#limitations
How are generally slightly more complex data structures like this implemented in data sources?

Edit: Took a look at #13908 and implemented in a similar manner, handling schema just as the same type as in the original resource (in this case json as string).

Via

dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceBigQueryTable().Schema)

`google_bigquery_table`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[ramonvermeulen]

After final changes:

➜ make testacc TEST=./google/services/bigquery TESTARGS='-run=TestAccDataSourceGoogleBigqueryTable_basic'

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/bigquery -v -run=TestAccDataSourceGoogleBigqueryTable_basic -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceGoogleBigqueryTable_basic
=== PAUSE TestAccDataSourceGoogleBigqueryTable_basic
=== CONT  TestAccDataSourceGoogleBigqueryTable_basic
--- PASS: TestAccDataSourceGoogleBigqueryTable_basic (13.03s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/bigquery 13.741s

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 324 insertions(+))
google-beta provider: Diff ( 4 files changed, 324 insertions(+))

[modular-magician]

Tests analytics

Total tests: 134
Passed tests: 123
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages

• bigquery

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleBigqueryTable_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleBigqueryTable_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[c2thorn]

thanks for the contribution @ramonvermeulen, this looks good to me.
Did you find the documentation to do this sufficient? https://googlecloudplatform.github.io/magic-modules/develop/add-handwritten-datasource/

[ramonvermeulen]

thanks for the contribution @ramonvermeulen, this looks good to me. Did you find the documentation to do this sufficient? https://googlecloudplatform.github.io/magic-modules/develop/add-handwritten-datasource/

@c2thorn

Thanks for your review!

Yes, I think in general the mmv1 documentation is in quite a good shape. Maybe if it needs to improved, at point 2 I would add something related to the existence of tpgresource.DatasourceSchemaFromResourceSchema. For a lot of data sources I think this is really useful, unless you want a different Schema than the original resource.