Skip to content

Convert review functions to go-gh#14031

Merged
ScottSuarez merged 5 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:go-gh-4
May 22, 2025
Merged

Convert review functions to go-gh#14031
ScottSuarez merged 5 commits intoGoogleCloudPlatform:mainfrom
ScottSuarez:go-gh-4

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

@ScottSuarez ScottSuarez commented May 19, 2025

closes hashicorp/terraform-provider-google#17191

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@ScottSuarez ScottSuarez requested review from melinath and removed request for melinath May 19, 2025 18:15
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez requested a review from melinath May 19, 2025 18:31
@ScottSuarez
Copy link
Copy Markdown
Contributor Author

ScottSuarez commented May 19, 2025

Not sure if we want to close hashicorp/terraform-provider-google#17191 after this gets merge.

There is still one function, (MergePullRequest) that I have not converted and won't be as part of this fixit.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

2 similar comments
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@github-actions
Copy link
Copy Markdown

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@melinath
Copy link
Copy Markdown
Member

Not sure if we want to close hashicorp/terraform-provider-google#17191 after this gets merge.

There is still one function, (MergePullRequest) that I have not converted and won't be as part of this fixit.

sure, let's close it. We can open a new ticket in the future if needed.

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the failure requesting service team reviewers.

Comment thread .ci/magician/github/set.go
Comment thread .ci/magician/github/set.go
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez added this pull request to the merge queue May 22, 2025
Merged via the queue into GoogleCloudPlatform:main with commit aaabc87 May 22, 2025
23 checks passed
@ScottSuarez ScottSuarez deleted the go-gh-4 branch May 22, 2025 18:38
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use go-github to interact with GitHub from Magician

3 participants