source service API and service package for all 99% of TGC resources by ScottSuarez · Pull Request #14045 · GoogleCloudPlatform/magic-modules

ScottSuarez · 2025-05-20T21:48:26Z

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2025-05-20T22:00:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 374 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 374 insertions(+), 32 deletions(-))

modular-magician · 2025-05-20T22:00:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 374 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 374 insertions(+), 32 deletions(-))

modular-magician · 2025-05-20T22:02:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 374 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 374 insertions(+), 32 deletions(-))

modular-magician · 2025-05-21T00:00:55Z

Tests analytics

Total tests: 4967
Passed tests: 4505
Skipped tests: 460
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician · 2025-05-21T00:02:40Z

Tests analytics

Total tests: 4967
Passed tests: 4503
Skipped tests: 460
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician · 2025-05-21T00:04:55Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-21T00:05:06Z

Tests analytics

Total tests: 4967
Passed tests: 4503
Skipped tests: 460
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccUniverseDomainDiskImage

Get to know how VCR tests work

modular-magician · 2025-05-21T00:15:01Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccUniverseDomainDiskImage [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-21T00:15:02Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

zli82016 · 2025-05-21T17:26:36Z

+	}
+
+	// Last resort: try relative to current directory
+	currentDir, err := os.Getwd()


Is the last try for relative directory enough? Are the other options (finding project root, environment variable) necessary?

I would like to keep find project root as i think this is the most adaptable? but I am not sure, yes the relative could be good enough. I removed the other paths as they are not used.

modular-magician · 2025-05-21T20:51:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 365 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 365 insertions(+), 32 deletions(-))

modular-magician · 2025-05-21T20:53:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 365 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 365 insertions(+), 32 deletions(-))

modular-magician · 2025-05-21T22:52:49Z

Tests analytics

Total tests: 5003
Passed tests: 4532
Skipped tests: 465
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccApigeeAddonsConfig_apigeeAddonsTestExample

TestAccBinaryAuthorizationPolicy_update

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician · 2025-05-21T22:57:52Z

Tests analytics

Total tests: 5003
Passed tests: 4533
Skipped tests: 465
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccApigeeAddonsConfig_apigeeAddonsTestExample

TestAccBinaryAuthorizationPolicy_update

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician · 2025-05-21T23:06:26Z

🟢 Tests passed during RECORDING mode:
TestAccBinaryAuthorizationPolicy_update [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-21T23:14:13Z

🟢 Tests passed during RECORDING mode:
TestAccApigeeAddonsConfig_apigeeAddonsTestExample [Debug log]
TestAccBinaryAuthorizationPolicy_update [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-21T23:55:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 363 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 3 files changed, 363 insertions(+), 32 deletions(-))

modular-magician · 2025-05-22T02:01:12Z

Tests analytics

Total tests: 5009
Passed tests: 4537
Skipped tests: 466
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

#### Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample

TestAccComputeFirewallPolicyWithRules_update

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician · 2025-05-22T02:19:54Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log]
TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…oogleCloudPlatform#14045)

source service API and service package for all 99% of TGC resources

37fc258

ScottSuarez requested a review from zli82016 May 20, 2025 21:48

ScottSuarez commented May 20, 2025

View reviewed changes

Comment thread mmv1/third_party/terraform/acctest/tgc_utils.go Outdated

ScottSuarez added 2 commits May 20, 2025 14:49

Update mmv1/third_party/terraform/acctest/tgc_utils.go

f719f47

service package for unknown value

0f4a9ce