Skip to content

Add create_ignore_already_exists to google_cloud_identity_group_membership#14250

Merged
slevenick merged 3 commits intoGoogleCloudPlatform:mainfrom
bjfish25:create_ignore_already_exists-groupmembership
Jun 23, 2025
Merged

Add create_ignore_already_exists to google_cloud_identity_group_membership#14250
slevenick merged 3 commits intoGoogleCloudPlatform:mainfrom
bjfish25:create_ignore_already_exists-groupmembership

Conversation

@bjfish25
Copy link
Copy Markdown
Contributor

@bjfish25 bjfish25 commented Jun 12, 2025

Adding create_ignore_already_exists field to google_cloud_identity_group_membership resource

Part of hashicorp/terraform-provider-google#19790

Release Note Template for Downstream PRs (will be copied)

cloudidentity: added `create_ignore_already_exists` field to `google_cloud_identity_group_membership` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 12, 2025
@bjfish25 bjfish25 marked this pull request as ready for review June 12, 2025 14:01
@github-actions github-actions bot requested a review from slevenick June 12, 2025 14:02
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Comment thread mmv1/products/cloudidentity/GroupMembership.yaml Outdated
Comment thread mmv1/products/cloudidentity/GroupMembership.yaml Outdated
@github-actions github-actions bot requested a review from slevenick June 16, 2025 16:24
@bjfish25 bjfish25 force-pushed the create_ignore_already_exists-groupmembership branch from 42fa0e9 to b01328b Compare June 16, 2025 18:15
@github-actions
Copy link
Copy Markdown

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Comment thread mmv1/templates/terraform/pre_create/cloud_identity_group_membership.go.tmpl Outdated
@github-actions github-actions bot requested a review from slevenick June 19, 2025 15:26
@modular-magician modular-magician added service/cloudidentity-groups and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 23, 2025
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 266 insertions(+))
google-beta provider: Diff ( 4 files changed, 266 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_identity_group_membership (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_identity_group_membership" "primary" {
  create_ignore_already_exists = # value needed
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1
Passed tests: 1
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudidentity
🟢 All tests passed!

View the build log

@slevenick slevenick added this pull request to the merge queue Jun 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 527d99e Jun 23, 2025
25 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants