fix: (storage) data type change for retention_period by gurusai-voleti · Pull Request #14269 · GoogleCloudPlatform/magic-modules

gurusai-voleti · 2025-06-13T12:30:57Z

Release Note Template for Downstream PRs (will be copied)
Fixes: hashicorp/terraform-provider-google#19051
See Write release notes for guidance.

storage: changed `retention_period` to `string` data type in resource `google_storage_bucket`

modular-magician · 2025-06-13T12:44:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 16 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+), 1 deletion(-))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2025-06-13T12:46:58Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-06-13T13:00:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-06-13T14:27:03Z

Tests analytics

Total tests: 120
Passed tests: 109
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-06-13T14:38:13Z

🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_storageClass [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-06-13T16:08:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-06-13T17:35:31Z

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-06-16T10:32:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 19 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 19 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2025-06-16T10:35:12Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-06-16T12:13:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-06-16T13:40:32Z

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-06-16T15:04:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-06-16T15:39:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 21 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 21 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-06-16T16:32:25Z

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-06-16T17:06:51Z

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2025-06-17T05:10:46Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-06-17T05:40:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

kautikdk · 2025-06-17T05:45:11Z

We might need state upgrader for this breaking change. Can you please check if that will be helpful?
References: https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/state-migration
https://github.com/GoogleCloudPlatform/magic-modules/pull/11471/files

modular-magician · 2025-06-17T07:07:42Z

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2025-06-18T05:32:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 558 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 5 files changed, 558 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

gurusai-voleti · 2025-06-18T06:01:16Z

added state upgrader

modular-magician · 2025-06-18T06:58:44Z

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

github-actions · 2025-06-19T09:43:34Z

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

kautikdk · 2025-06-19T12:47:53Z

@BBBmau can you please review the state migration code as it was historically added/written by only magic-modules maintainers?

github-actions · 2025-06-23T09:44:24Z

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

kautikdk · 2025-06-24T18:58:27Z

mmv1/third_party/terraform/website/docs/r/storage_bucket.html.markdown

 * `is_locked` - (Optional) If set to `true`, the bucket will be [locked](https://cloud.google.com/storage/docs/using-bucket-lock#lock-bucket) and permanently restrict edits to the bucket's retention policy.  Caution: Locking a bucket is an irreversible action.

-* `retention_period` - (Required) The period of time, in seconds, that objects in the bucket must be retained and cannot be deleted, overwritten, or archived. The value must be less than 2,147,483,647 seconds.
+* `retention_period` - (Required) The period of time, in seconds, that objects in the bucket must be retained and cannot be deleted, overwritten, or archived. The value must be less than 3,155,760,000 seconds.


Is the upper limit coming from server side value limit?

yes as per API its the latest value

kautikdk · 2025-06-24T19:07:21Z

mmv1/third_party/tgc/services/storage/storage_bucket.go

 	}
 	retentionPolicy := retentionPolicies[0].(map[string]interface{})

+	value, _ := strconv.ParseInt(retentionPolicy["retention_period"].(string), 10, 64)


How this change will impact users? I am not very familiar with the tgc converters and how/when they are used.

I also don't know much about these converters, but this is failing when building, so fixed the issue https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/15634595262/job/44046728184

modular-magician · 2025-06-27T05:21:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 561 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 5 files changed, 561 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field retention_policy.retention_period changed from TypeInt to TypeString on google_storage_bucket - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

Failed to detect subcategory in the frontmatter in file website/docs/guides/version_7_upgrade.html.markdown.

modular-magician · 2025-06-27T06:49:50Z

Tests analytics

Total tests: 123
Passed tests: 111
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-06-27T06:52:24Z

🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_storageClass [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_IPFilter [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

gurusai-voleti · 2025-06-27T06:55:17Z

unrelated test case is failing

github-actions · 2025-06-30T09:44:58Z

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

gurusai-voleti · 2025-06-30T10:26:12Z

@rileykarson (current oncall) need help on reviewing this item

NickElliot · 2025-06-30T22:46:12Z

Hi -- commenting to say for the time being to avoid merging this PR because we're making some changes to the feature branches, should be resolved some time tomorrow and will update then!

c2thorn · 2025-07-01T20:58:08Z

reached out to @gurusai-voleti offline to discuss the options for removing the conflicts

modular-magician · 2025-07-02T06:00:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician · 2025-07-02T06:01:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

gurusai-voleti · 2025-07-02T07:17:02Z

new PR #14442 has been created, closing this PR

add upgrade guide to 7.0.0 branch (GoogleCloudPlatform#13790)

1ac09c6

modular-magician added the service/storage label Jun 13, 2025

modular-magician requested a review from kautikdk June 13, 2025 12:44

gurusai-voleti marked this pull request as ready for review June 17, 2025 05:09

github-actions bot requested a review from BBBmau June 17, 2025 05:10

kautikdk reviewed Jun 24, 2025

View reviewed changes

gurusai-voleti requested a review from kautikdk June 26, 2025 09:50

c2thorn added the 7.0.0 label Jun 30, 2025

c2thorn deleted the branch GoogleCloudPlatform:FEATURE-BRANCH-major-release-7.0.0 July 1, 2025 16:37

c2thorn closed this Jul 1, 2025

c2thorn reopened this Jul 1, 2025

gurusai-voleti force-pushed the retention_prd branch from 5cc887c to 1ac09c6 Compare July 2, 2025 05:50

Merge branch 'FEATURE-BRANCH-major-release-7.0.0' into retention_prd

279e1e7

gurusai-voleti mentioned this pull request Jul 2, 2025

fix: (storage) data type change for retention_period #14442

Merged

gurusai-voleti closed this Jul 2, 2025

Conversation

gurusai-voleti commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jun 13, 2025

Diff report

Errors

Uh oh!

modular-magician commented Jun 13, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 13, 2025

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Jun 13, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Jun 13, 2025

Uh oh!

modular-magician commented Jun 13, 2025

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Jun 13, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 16, 2025

Diff report

Errors

Uh oh!

modular-magician commented Jun 16, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 16, 2025

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Jun 16, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 16, 2025

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Jun 16, 2025

Diff report

Breaking Change(s) Detected

Uh oh!

modular-magician commented Jun 16, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 16, 2025

Tests analytics

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

modular-magician commented Jun 17, 2025

Diff report

Breaking Change(s) Detected

Uh oh!

kautikdk commented Jun 17, 2025

Uh oh!

modular-magician commented Jun 17, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 18, 2025

Diff report

Breaking Change(s) Detected

Uh oh!

gurusai-voleti commented Jun 18, 2025

Uh oh!

modular-magician commented Jun 18, 2025

Tests analytics

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

kautikdk commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gurusai-voleti commented Jun 13, 2025 •

edited

Loading

kautikdk commented Jun 19, 2025 •

edited

Loading

gurusai-voleti Jun 25, 2025 •

edited

Loading