Skip to content

Promote launch stage to BETA#14294

Merged
hao-nan-li merged 1 commit intoGoogleCloudPlatform:mainfrom
paridhishah18:wp-launch-stage
Jun 24, 2025
Merged

Promote launch stage to BETA#14294
hao-nan-li merged 1 commit intoGoogleCloudPlatform:mainfrom
paridhishah18:wp-launch-stage

Conversation

@paridhishah18
Copy link
Copy Markdown
Contributor

@paridhishah18 paridhishah18 commented Jun 17, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@paridhishah18
Copy link
Copy Markdown
Contributor Author

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 31 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 5 files changed, 31 insertions(+), 31 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 8 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 79
Passed tests: 57
Skipped tests: 8
Affected tests: 14

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2WorkerPoolIamBindingGenerated
  • TestAccCloudRunV2WorkerPoolIamMemberGenerated
  • TestAccCloudRunV2WorkerPoolIamPolicyGenerated
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolAttributionLabel
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolBasicExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolCustomAudienceUpdate
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolCustomAudiencesExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolDirectvpcExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolFullUpdate
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolLimitsExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSecretExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSqlExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithDirectVPCUpdate
  • TestAccDataSourceGoogleCloudRunV2WorkerPool_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2WorkerPoolIamBindingGenerated [Debug log]
TestAccCloudRunV2WorkerPoolIamMemberGenerated [Debug log]
TestAccCloudRunV2WorkerPoolIamPolicyGenerated [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolAttributionLabel [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolBasicExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolCustomAudienceUpdate [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolCustomAudiencesExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolDirectvpcExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolFullUpdate [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolLimitsExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSecretExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSqlExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithDirectVPCUpdate [Debug log]
TestAccDataSourceGoogleCloudRunV2WorkerPool_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@paridhishah18 paridhishah18 marked this pull request as ready for review June 18, 2025 17:00
@github-actions github-actions bot requested a review from BBBmau June 18, 2025 17:00
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@kminsu-google
Copy link
Copy Markdown
Member

LGTM

@github-actions
Copy link
Copy Markdown

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@paridhishah18
Copy link
Copy Markdown
Contributor Author

paridhishah18 commented Jun 23, 2025

@BBBmau Could you please review the PR? Thanks! It has been LGTM'd by a team member.

@paridhishah18
Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@paridhishah18
Copy link
Copy Markdown
Contributor Author

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 33 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 5 files changed, 33 insertions(+), 35 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 9 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 81
Passed tests: 71
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMulticontainerExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMulticontainerExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@hao-nan-li hao-nan-li requested review from hao-nan-li and removed request for BBBmau June 24, 2025 18:22
Copy link
Copy Markdown
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure, does this change include all necessary test to modify? If there's any occurrence of launch_stage left in the test, do they expect to pass?

@paridhishah18
Copy link
Copy Markdown
Contributor Author

Just want to make sure, does this change include all necessary test to modify? If there's any occurrence of launch_stage left in the test, do they expect to pass?

There are two other tests

  1. ManualScaling which needs some more debugging. So I'll fix in separate PR

  2. GPU this needs some more debugging but it would stay in ALPHA itself.

@github-actions github-actions bot requested a review from hao-nan-li June 24, 2025 18:35
Copy link
Copy Markdown
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for explaining, and good luck on fixing the other 2 tests.

@hao-nan-li hao-nan-li added this pull request to the merge queue Jun 24, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 45145b6 Jun 24, 2025
25 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants