Promote launch stage to BETA#14294
Conversation
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 79 Click here to see the affected service packages
Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
LGTM |
|
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@BBBmau Could you please review the PR? Thanks! It has been LGTM'd by a team member. |
|
@modular-magician reassign-reviewer |
fb0ca95 to
a2bb77f
Compare
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 81 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
hao-nan-li
left a comment
There was a problem hiding this comment.
Just want to make sure, does this change include all necessary test to modify? If there's any occurrence of launch_stage left in the test, do they expect to pass?
There are two other tests
|
45145b6
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.