Skip to content

Add support for GPU fields in Cloud Run v2 Job#14305

Merged
c2thorn merged 9 commits intoGoogleCloudPlatform:mainfrom
yanweiguo:gpu_job
Jun 23, 2025
Merged

Add support for GPU fields in Cloud Run v2 Job#14305
c2thorn merged 9 commits intoGoogleCloudPlatform:mainfrom
yanweiguo:gpu_job

Conversation

@yanweiguo
Copy link
Copy Markdown
Member

Adds support for GPU fields which requires changes to limits as well as adding a new field nodeSelector to job v2 api.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrunv2: added field `node_selector` to `google_cloud_run_v2_job` resource (beta) to support setting GPU.

@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 101 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 5 files changed, 238 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 122 insertions(+))

@modular-magician modular-magician requested a review from ian-mi June 18, 2025 17:57
@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate

Tests analytics

Total tests: 81
Passed tests: 68
Skipped tests: 9
Affected tests: 4

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobGpuExample
  • TestAccCloudRunV2Job_cloudrunv2JobWithDirectVPCUpdate
  • TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate
  • TestAccCloudRunV2Job_cloudrunv2JobWithStartExecutionTokenUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobWithDirectVPCUpdate [Debug log]
TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate [Debug log]
TestAccCloudRunV2Job_cloudrunv2JobWithStartExecutionTokenUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobGpuExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Comment thread mmv1/templates/terraform/examples/cloudrunv2_job_gpu.tf.tmpl Outdated
@github-actions github-actions bot requested a review from c2thorn June 18, 2025 19:04
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 101 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 5 files changed, 238 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 122 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate

Tests analytics

Total tests: 81
Passed tests: 71
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobGpuExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobGpuExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 50 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 5 files changed, 238 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate

Tests analytics

Total tests: 81
Passed tests: 71
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobGpuExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobGpuExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 46 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 5 files changed, 230 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate

Tests analytics

Total tests: 81
Passed tests: 71
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobGpuExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobGpuExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 46 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 5 files changed, 230 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate

Tests analytics

Total tests: 81
Passed tests: 71
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobGpuExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobGpuExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 46 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 5 files changed, 230 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccCloudRunV2Job_cloudrunv2JobWithGpuUpdate

Tests analytics

Total tests: 81
Passed tests: 71
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobGpuExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Job_cloudrunv2JobGpuExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions
Copy link
Copy Markdown

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn c2thorn added this pull request to the merge queue Jun 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 87ab79b Jun 23, 2025
26 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants