Update Access Context Manager Test for user types#14311
Update Access Context Manager Test for user types#14311zli82016 merged 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Removing the draft label. I think the failing test is unrelated and I see the test I'm updating is passing again. |
Similar to GoogleCloudPlatform#14311 except for the service perimeter test case. These test identities are actually groups, but were incorrectly being passed as users.
|
The failed test @coder-221, can you add the Github issue you are trying to fix to the |
|
Thanks @zli82016 for confirming the failing test is unrelated. I don't think there's a public GitHub issue tracking this issue. Do you have a link to the CI failures and maybe we can add that if it would help? |
|
@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@coder-221, thanks for the information. What issue/error are you trying to fix in this PR? |
58ae945
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
I think this test is failing because the members in the access level are incorrect. The IAM principal prefix should match the type of the principal. The principal type in this case should be group not user since the principals are groups.