Removed Immutability for log_linked_dataset_query_user_email#14316
Removed Immutability for log_linked_dataset_query_user_email#14316shuyama1 merged 9 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 17 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 17 Click here to see the affected service packages
View the build log |
shuyama1
left a comment
There was a problem hiding this comment.
Thanks for the changes! Could you please add a new test or update an existing one to cover the update functionality?
https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 17 Click here to see the affected service packages
View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 17 Click here to see the affected service packages
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Added |
shuyama1
left a comment
There was a problem hiding this comment.
Thanks for the quick update! Mostly good, just some small comments
| @@ -150,4 +150,3 @@ properties: | |||
| type: Boolean | |||
| description: | |||
| If true, subscriber email logging is enabled and all queries on the linked dataset will log the email address of the querying user. | |||
There was a problem hiding this comment.
Your PR description mentions that this field can't be turned off once it's enabled.
Would you mind adding that to the field description?
| @@ -241,4 +241,3 @@ properties: | |||
| type: Boolean | |||
| description: | |||
| If true, subscriber email logging is enabled and all queries on the linked dataset will log the email address of the querying user. | |||
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 17 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 17 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 17 Click here to see the affected service packages
View the build log |
4237412
Subscriber email logging is not an immutable resource. Once enabled, it cannot be turned off (prevented by APIs directly), but if it was initially off, it can be enabled.