Skip to content

Removed Immutability for log_linked_dataset_query_user_email#14316

Merged
shuyama1 merged 9 commits intoGoogleCloudPlatform:mainfrom
arnavdham:arnavdham-ah2
Jun 24, 2025
Merged

Removed Immutability for log_linked_dataset_query_user_email#14316
shuyama1 merged 9 commits intoGoogleCloudPlatform:mainfrom
arnavdham:arnavdham-ah2

Conversation

@arnavdham
Copy link
Copy Markdown
Contributor

@arnavdham arnavdham commented Jun 19, 2025

Subscriber email logging is not an immutable resource. Once enabled, it cannot be turned off (prevented by APIs directly), but if it was initially off, it can be enabled.

bigqueryanalyticshub: supported in-place update for `log_linked_dataset_query_user_email` in `google_bigquery_analytics_hub_listing` and `google_bigquery_analytics_hub_data_exchange` resources. Once enabled, this feature cannot be disabled.

@github-actions github-actions bot requested a review from shuyama1 June 19, 2025 16:00
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 20 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 20 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 20 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 20 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryanalyticshub
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryanalyticshub
🟢 All tests passed!

View the build log

Copy link
Copy Markdown
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Could you please add a new test or update an existing one to cover the update functionality?

https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test

@github-actions github-actions bot requested a review from shuyama1 June 20, 2025 04:14
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 20 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 20 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryanalyticshub
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 25 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 25 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • bigqueryanalyticshub
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@arnavdham
Copy link
Copy Markdown
Contributor Author

Thanks for the changes! Could you please add a new test or update an existing one to cover the update functionality?

https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-update-test

Added

Copy link
Copy Markdown
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update! Mostly good, just some small comments

@@ -150,4 +150,3 @@ properties:
type: Boolean
description:
If true, subscriber email logging is enabled and all queries on the linked dataset will log the email address of the querying user.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR description mentions that this field can't be turned off once it's enabled.
Would you mind adding that to the field description?

@@ -241,4 +241,3 @@ properties:
type: Boolean
description:
If true, subscriber email logging is enabled and all queries on the linked dataset will log the email address of the querying user.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@github-actions github-actions bot requested a review from shuyama1 June 21, 2025 07:29
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 29 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 29 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 29 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 29 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 29 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 29 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryanalyticshub
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryanalyticshub
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryanalyticshub
🟢 All tests passed!

View the build log

@shuyama1 shuyama1 added this pull request to the merge queue Jun 24, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 4237412 Jun 24, 2025
28 checks passed
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants