Make description and displayName optional and mutable

[kjordy]

Made description and displayName optional and mutable in MetricDescriptor.yaml and updated the conformance tests in resource_monitoring_metric_descriptor_test.go.

Fixes hashicorp/terraform-provider-google#22949
Fixes hashicorp/terraform-provider-google#7682

Release Note Template for Downstream PRs (will be copied)

monitoring: made `description` and `displayName` optional and mutable in `google_monitoring_metric_descriptor`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+), 41 deletions(-))
google-beta provider: Diff ( 3 files changed, 54 insertions(+), 41 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+), 41 deletions(-))
google-beta provider: Diff ( 3 files changed, 54 insertions(+), 41 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• monitoring

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• monitoring

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 3 files changed, 54 insertions(+), 27 deletions(-))

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 54
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages

• monitoring

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMonitoringMetricDescriptor_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccMonitoringMetricDescriptor_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[c2thorn]

just removing the immutable fields for slightly better readability, this should have no functional change

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 3 files changed, 54 insertions(+), 27 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 3 files changed, 54 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• monitoring

🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 58
Passed tests: 55
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• monitoring

🟢 All tests passed!

View the build log