tgc-revival: support compute tgc autoscaler#14330
tgc-revival: support compute tgc autoscaler#14330zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
a9b4162 to
cc0e204
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
defe1e6 to
72ddb6d
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
trodge
left a comment
There was a problem hiding this comment.
I think we should be able to have shared function templates for TGC the way we do for TPG.
| ignore_read: true | ||
| default_from_api: true | ||
| custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl' | ||
| custom_tgc_flatten: 'templates/tgc_next/custom_flatten/compute_auto_scaler.go.tmpl' |
There was a problem hiding this comment.
Since the custom_expand is a template used by many resources, can we use a similar approach in TGC to not need a separate template for each resource?
trodge
left a comment
There was a problem hiding this comment.
As discussed offline, we'll merge this for now and refactor later to a more generic method of handling zone, region and location fields when we have more resources covered.
45ee20b
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.