Skip to content

tgc-revival: support compute tgc autoscaler#14330

Merged
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:tgc-autoscaler
Jun 23, 2025
Merged

tgc-revival: support compute tgc autoscaler#14330
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:tgc-autoscaler

Conversation

@zli82016
Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@zli82016 zli82016 force-pushed the tgc-autoscaler branch 2 times, most recently from a9b4162 to cc0e204 Compare June 20, 2025 23:02
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 8 files changed, 1520 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 8 files changed, 1520 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 8 files changed, 1520 insertions(+), 15 deletions(-))

@zli82016 zli82016 force-pushed the tgc-autoscaler branch 3 times, most recently from defe1e6 to 72ddb6d Compare June 20, 2025 23:40
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 1510 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 1510 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 1510 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 1510 insertions(+), 5 deletions(-))

@zli82016 zli82016 marked this pull request as ready for review June 21, 2025 00:22
@zli82016 zli82016 requested a review from trodge June 23, 2025 16:30
Copy link
Copy Markdown
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be able to have shared function templates for TGC the way we do for TPG.

ignore_read: true
default_from_api: true
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl'
custom_tgc_flatten: 'templates/tgc_next/custom_flatten/compute_auto_scaler.go.tmpl'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the custom_expand is a template used by many resources, can we use a similar approach in TGC to not need a separate template for each resource?

@trodge trodge self-requested a review June 23, 2025 21:29
Copy link
Copy Markdown
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we'll merge this for now and refactor later to a more generic method of handling zone, region and location fields when we have more resources covered.

@zli82016 zli82016 added this pull request to the merge queue Jun 23, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 45ee20b Jun 23, 2025
27 checks passed
@zli82016 zli82016 deleted the tgc-autoscaler branch June 23, 2025 21:55
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants