Skip to content

Modify the primary resource name for disk_async test#14347

Merged
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:disk-test
Jun 24, 2025
Merged

Modify the primary resource name for disk_async test#14347
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:disk-test

Conversation

@zli82016
Copy link
Copy Markdown
Member

@zli82016 zli82016 commented Jun 24, 2025

The resource secondary should be the primary resource in the acceptance test to test its field async_primary_disk

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1225
Passed tests: 1141
Skipped tests: 83
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_diskAsyncExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeDisk_diskAsyncExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016 zli82016 marked this pull request as ready for review June 24, 2025 17:52
@zli82016 zli82016 requested a review from hao-nan-li June 24, 2025 17:54
@zli82016 zli82016 added this pull request to the merge queue Jun 24, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 52cbd62 Jun 24, 2025
27 checks passed
@zli82016 zli82016 deleted the disk-test branch June 24, 2025 18:15
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants