Adding Terraform support for Model Armor by srichaitanyab · Pull Request #14349 · GoogleCloudPlatform/magic-modules

srichaitanyab · 2025-06-24T17:31:59Z

Adding the 'Template' resource of Model Armor

Release Note Template for Downstream PRs (will be copied)

`google_model_armor_template`

github-actions · 2025-06-24T17:41:06Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-06-24T17:44:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2817 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2807 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 481 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 560 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_model_armor_template

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-06-24T17:50:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2817 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2807 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 481 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 560 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_model_armor_template

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-06-24T19:48:59Z

Tests analytics

Total tests: 5319
Passed tests: 4694
Skipped tests: 588
Affected tests: 37

Click here to see the affected service packages

All service packages are affected

#### Action taken

Found 37 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__gcp_user_access_binding

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccContainerNodePool_EmptyGuestAccelerator

TestAccContainerNodePool_autoscaling

TestAccContainerNodePool_fastSocket

TestAccContainerNodePool_gcfsConfig

TestAccContainerNodePool_gvnic

TestAccContainerNodePool_privateRegistry

TestAccContainerNodePool_regionalAutoscaling

TestAccContainerNodePool_resize

TestAccContainerNodePool_resourceManagerTags

TestAccContainerNodePool_totalSize

TestAccContainerNodePool_version

TestAccContainerNodePool_withCgroupMode

TestAccContainerNodePool_withConfidentialNodes

TestAccContainerNodePool_withEnablePrivateNodesToggle

TestAccContainerNodePool_withHugepageConfig

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withLinuxNodeConfig

TestAccContainerNodePool_withLoggingVariantUpdates

TestAccContainerNodePool_withMachineAndDiskUpdate

TestAccContainerNodePool_withManagement

TestAccContainerNodePool_withMaxRunDuration

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withNodeConfig

TestAccContainerNodePool_withTaintsUpdate

TestAccContainerNodePool_withUpgradeSettings

TestAccContainerNodePool_withWindowsNodeConfig

TestAccContainerNodePool_withWorkloadIdentityConfig

TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccModelArmorTemplate_basic

TestAccModelArmorTemplate_modelarmorTemplateBasicExample

TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample

TestAccModelArmorTemplate_modelarmorTemplateLabelExample

TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample

TestAccModelArmorTemplate_update

Get to know how VCR tests work

modular-magician · 2025-06-24T19:55:55Z

Tests analytics

Total tests: 5319
Passed tests: 4695
Skipped tests: 588
Affected tests: 36

Click here to see the affected service packages

All service packages are affected

#### Action taken

Found 36 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__gcp_user_access_binding

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccContainerNodePool_EmptyGuestAccelerator

TestAccContainerNodePool_autoscaling

TestAccContainerNodePool_fastSocket

TestAccContainerNodePool_gcfsConfig

TestAccContainerNodePool_gvnic

TestAccContainerNodePool_privateRegistry

TestAccContainerNodePool_regionalAutoscaling

TestAccContainerNodePool_resize

TestAccContainerNodePool_resourceManagerTags

TestAccContainerNodePool_totalSize

TestAccContainerNodePool_version

TestAccContainerNodePool_withCgroupMode

TestAccContainerNodePool_withConfidentialNodes

TestAccContainerNodePool_withEnablePrivateNodesToggle

TestAccContainerNodePool_withHugepageConfig

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withLinuxNodeConfig

TestAccContainerNodePool_withLoggingVariantUpdates

TestAccContainerNodePool_withManagement

TestAccContainerNodePool_withMaxRunDuration

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withNodeConfig

TestAccContainerNodePool_withTaintsUpdate

TestAccContainerNodePool_withUpgradeSettings

TestAccContainerNodePool_withWindowsNodeConfig

TestAccContainerNodePool_withWorkloadIdentityConfig

TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccModelArmorTemplate_basic

TestAccModelArmorTemplate_modelarmorTemplateBasicExample

TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample

TestAccModelArmorTemplate_modelarmorTemplateLabelExample

TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample

TestAccModelArmorTemplate_update

Get to know how VCR tests work

modular-magician · 2025-06-24T22:10:42Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]
TestAccModelArmorTemplate_basic [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateBasicExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateLabelExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample [Debug log]
TestAccModelArmorTemplate_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-24T22:14:31Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_resourceManagerTags [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]
TestAccModelArmorTemplate_basic [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateBasicExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateLabelExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample [Debug log]
TestAccModelArmorTemplate_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

srichaitanyab · 2025-06-25T05:22:11Z

Hi, the failing tests are actually not from my project or changes. Hence, could you guide me on any changes that I might have to make about them, if any?

melinath · 2025-06-25T23:42:18Z

you don't need to make changes to failing tests outside of ModelArmor since they're not related to your change; we just can't know that automatically because adding a new service has to touch global files.

melinath

overall this looks pretty good; I need to take a closer pass before approving though.

melinath · 2025-06-25T23:59:28Z

+	step1Checks := func(ctx map[string]interface{}) []resource.TestCheckFunc {
+		return []resource.TestCheckFunc{
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "labels.test-label", ctx["label_test_label"].(string)),
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.advanced_config.0.inspect_template", ctx["filter_config_sdp_settings_advanced_config_inspect_template"].(string)),
+		}
+	}
+
+	step2Checks := func(ctx map[string]interface{}) []resource.TestCheckFunc {
+		checks := []resource.TestCheckFunc{
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "labels.test-label", ctx["label_test_label"].(string)),
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.rai_settings.0.rai_filters.0.filter_type", ctx["filter_config_rai_settings_rai_filters_0_filter_type"].(string)),
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "template_metadata.0.log_sanitize_operations", "false"),
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.#", "1"),
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.basic_config.#", "1"),
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.basic_config.0.filter_enforcement", ctx["filter_config_sdp_settings_basic_config_filter_enforcement"].(string)),
+			resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.advanced_config.#", "0"),
+		}
+		return checks
+	}


Suggested change

step1Checks := func(ctx map[string]interface{}) []resource.TestCheckFunc {

return []resource.TestCheckFunc{

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "labels.test-label", ctx["label_test_label"].(string)),

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.advanced_config.0.inspect_template", ctx["filter_config_sdp_settings_advanced_config_inspect_template"].(string)),

}

}

step2Checks := func(ctx map[string]interface{}) []resource.TestCheckFunc {

checks := []resource.TestCheckFunc{

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "labels.test-label", ctx["label_test_label"].(string)),

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.rai_settings.0.rai_filters.0.filter_type", ctx["filter_config_rai_settings_rai_filters_0_filter_type"].(string)),

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "template_metadata.0.log_sanitize_operations", "false"),

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.#", "1"),

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.basic_config.#", "1"),

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.basic_config.0.filter_enforcement", ctx["filter_config_sdp_settings_basic_config_filter_enforcement"].(string)),

resource.TestCheckResourceAttr("google_model_armor_template.test-resource", "filter_config.0.sdp_settings.0.advanced_config.#", "0"),

}

return checks

}

Generally speaking we don't rely on explicit attribute checks - instead, we use ImportStateVerify steps. For example: https://github.com/hashicorp/terraform-provider-google/blob/0ca0b4b187c09a36fe427f8cb5d3026c83a94910/google/services/osconfig/resource_os_config_patch_deployment_generated_test.go#L48-L53

This will check that the values on the resource are correct and also exercise the import logic.

melinath · 2025-06-26T00:00:35Z

+		"template_metadata_enforcement_type":                                         "INSPECT_AND_BLOCK",
+	}
+
+	const config_template = `


Generally we recommend putting the config in a separate function, similar to https://github.com/hashicorp/terraform-provider-google/blob/0ca0b4b187c09a36fe427f8cb5d3026c83a94910/google/services/osconfig/resource_os_config_patch_deployment_generated_test.go#L46, but this doesn't seem to be causing problems with our test parsing logic so it may be fine.

modular-magician · 2025-06-26T07:01:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2774 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2764 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 481 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 560 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_model_armor_template

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

srichaitanyab · 2025-06-26T07:45:29Z

I've added the google_model_armor_* label to the proto, yet it still fails. Please look into this and lmk about any further changes.

modular-magician · 2025-06-26T09:09:58Z

Tests analytics

Total tests: 5328
Passed tests: 4707
Skipped tests: 588
Affected tests: 33

Click here to see the affected service packages

All service packages are affected

#### Action taken

Found 33 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__gcp_user_access_binding

TestAccAccessContextManager__service_perimeters

TestAccAlloydbInstance_createInstanceWithPscInterfaceConfigs

TestAccContainerNodePool_EmptyGuestAccelerator

TestAccContainerNodePool_autoscaling

TestAccContainerNodePool_fastSocket

TestAccContainerNodePool_gcfsConfig

TestAccContainerNodePool_gvnic

TestAccContainerNodePool_privateRegistry

TestAccContainerNodePool_regionalAutoscaling

TestAccContainerNodePool_resize

TestAccContainerNodePool_resourceManagerTags

TestAccContainerNodePool_totalSize

TestAccContainerNodePool_version

TestAccContainerNodePool_withCgroupMode

TestAccContainerNodePool_withConfidentialNodes

TestAccContainerNodePool_withEnablePrivateNodesToggle

TestAccContainerNodePool_withHugepageConfig

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withLinuxNodeConfig

TestAccContainerNodePool_withLoggingVariantUpdates

TestAccContainerNodePool_withMachineAndDiskUpdate

TestAccContainerNodePool_withManagement

TestAccContainerNodePool_withMaxRunDuration

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withNodeConfig

TestAccContainerNodePool_withTaintsUpdate

TestAccContainerNodePool_withUpgradeSettings

TestAccContainerNodePool_withWindowsNodeConfig

TestAccContainerNodePool_withWorkloadIdentityConfig

TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

TestAccModelArmorTemplate_update

Get to know how VCR tests work

modular-magician · 2025-06-26T11:20:10Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAlloydbInstance_createInstanceWithPscInterfaceConfigs [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_resourceManagerTags [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]
TestAccModelArmorTemplate_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

melinath

Some minor changes but overall LGTM. Seems like all the fields are tested & the new tests are passing.

modular-magician · 2025-06-27T15:20:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2640 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2630 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 481 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 500 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

google_model_armor_template

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

melinath · 2025-06-27T15:23:10Z

Service labels will be fixed by #14399

modular-magician · 2025-06-27T17:27:24Z

Tests analytics

Total tests: 5333
Passed tests: 4717
Skipped tests: 588
Affected tests: 28

Click here to see the affected service packages

All service packages are affected

#### Action taken

Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__gcp_user_access_binding

TestAccAccessContextManager__service_perimeters

TestAccContainerNodePool_EmptyGuestAccelerator

TestAccContainerNodePool_autoscaling

TestAccContainerNodePool_gvnic

TestAccContainerNodePool_privateRegistry

TestAccContainerNodePool_regionalAutoscaling

TestAccContainerNodePool_resize

TestAccContainerNodePool_resourceManagerTags

TestAccContainerNodePool_totalSize

TestAccContainerNodePool_version

TestAccContainerNodePool_withCgroupMode

TestAccContainerNodePool_withConfidentialNodes

TestAccContainerNodePool_withEnablePrivateNodesToggle

TestAccContainerNodePool_withHugepageConfig

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withLinuxNodeConfig

TestAccContainerNodePool_withLoggingVariantUpdates

TestAccContainerNodePool_withMachineAndDiskUpdate

TestAccContainerNodePool_withManagement

TestAccContainerNodePool_withMaxRunDuration

TestAccContainerNodePool_withNodeConfig

TestAccContainerNodePool_withTaintsUpdate

TestAccContainerNodePool_withUpgradeSettings

TestAccContainerNodePool_withWindowsNodeConfig

TestAccContainerNodePool_withWorkloadIdentityConfig

TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample

TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

srichaitanyab · 2025-06-27T19:05:43Z

Hi, could you please let me know about any other blocking issues?? If none, could you consider merging it?

modular-magician · 2025-06-27T19:17:06Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_resourceManagerTags [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

melinath

I was just waiting for the tests to finish running. Looks good; failures are unrelated.

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

srichaitanyab added 2 commits June 24, 2025 22:58

Adding terraform files for Model Armor v1

5d027dd

Added new lines at the end of files for indenation checks

2aca9f8

srichaitanyab marked this pull request as ready for review June 24, 2025 17:40

github-actions bot requested a review from melinath June 24, 2025 17:41

melinath requested changes Jun 26, 2025

View reviewed changes

srichaitanyab added 2 commits June 26, 2025 12:16

Changed checks to use ImportState, context checks now in a new function

bc7c9fe

Perfomed gofmt check on the test file

7101712

github-actions bot requested a review from melinath June 26, 2025 06:50

melinath requested changes Jun 27, 2025

View reviewed changes

Apply suggestions from code review

20bb976

github-actions bot requested a review from melinath June 27, 2025 00:17

melinath reviewed Jun 27, 2025

View reviewed changes

Comment thread mmv1/products/modelarmor/product.yaml Outdated

Update mmv1/products/modelarmor/product.yaml

0b361e9

github-actions bot requested a review from melinath June 27, 2025 00:21

melinath approved these changes Jun 27, 2025

View reviewed changes

melinath added this pull request to the merge queue Jun 27, 2025

Merged via the queue into GoogleCloudPlatform:main with commit 1e00d9f Jun 27, 2025
25 of 28 checks passed

jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025

Adding Terraform support for Model Armor (GoogleCloudPlatform#14349)

f588f9a

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Adding Terraform support for Model Armor (GoogleCloudPlatform#14349)

28ed342

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Adding Terraform support for Model Armor (GoogleCloudPlatform#14349)

427a2a0

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Adding Terraform support for Model Armor (GoogleCloudPlatform#14349)

0b5aa4a

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Adding Terraform support for Model Armor (GoogleCloudPlatform#14349)

1f78e09

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025

Adding Terraform support for Model Armor (GoogleCloudPlatform#14349)

05f009a

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Conversation

srichaitanyab commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

modular-magician commented Jun 24, 2025

Diff report

Missing service labels

Uh oh!

modular-magician commented Jun 24, 2025

Diff report

Missing service labels

Uh oh!

modular-magician commented Jun 24, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 24, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 24, 2025

Uh oh!

modular-magician commented Jun 24, 2025

Uh oh!

srichaitanyab commented Jun 25, 2025

Uh oh!

melinath commented Jun 25, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

melinath Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

melinath Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jun 26, 2025

Diff report

Missing service labels

Uh oh!

srichaitanyab commented Jun 26, 2025

Uh oh!

modular-magician commented Jun 26, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 26, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Jun 27, 2025

Diff report

Missing service labels

Uh oh!

melinath commented Jun 27, 2025

Uh oh!

modular-magician commented Jun 27, 2025

Tests analytics

Uh oh!

srichaitanyab commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jun 27, 2025

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

srichaitanyab commented Jun 24, 2025 •

edited

Loading

srichaitanyab commented Jun 27, 2025 •

edited

Loading