Iceberg Table by rambleraptor · Pull Request #16522 · GoogleCloudPlatform/magic-modules

rambleraptor · 2026-02-24T23:32:43Z

Release Note Template for Downstream PRs (will be copied)

`google_biglake_iceberg_table`

modular-magician · 2026-02-24T23:45:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 2709 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 9 files changed, 2709 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 793 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_biglake_iceberg_table (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_biglake_iceberg_table" "primary" {
  location = # value needed
  partition_spec {
    fields {
      name      = # value needed
      source_id = # value needed
      transform = # value needed
    }
  }
  schema {
    fields {
      doc = # value needed
    }
    identifier_field_ids = # value needed
  }
}

modular-magician · 2026-02-25T23:58:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2792 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 11 files changed, 2792 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 793 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 284 insertions(+))

modular-magician · 2026-02-26T02:24:11Z

Tests analytics

Total tests: 6087
Passed tests: 5444
Skipped tests: 636
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBiglakeIcebergIcebergTableIamBindingGenerated

TestAccBiglakeIcebergIcebergTableIamMemberGenerated

TestAccBiglakeIcebergIcebergTableIamPolicyGenerated

TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableBasicExample

TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableUpdateExample

TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate

TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController

Get to know how VCR tests work

modular-magician · 2026-02-26T03:08:23Z

🟢 Tests passed during RECORDING mode:
TestAccBiglakeIcebergIcebergTableIamBindingGenerated [Debug log]
TestAccBiglakeIcebergIcebergTableIamMemberGenerated [Debug log]
TestAccBiglakeIcebergIcebergTableIamPolicyGenerated [Debug log]
TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableBasicExample [Debug log]
TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableUpdateExample [Debug log]
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-02-26T18:23:33Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

c2thorn

Hey @rambleraptor! hope you are doing well.
Added some initial comments.

This resource has a lot of custom code! Can you give some more comments or explanation as to what makes the resource so abnormal to need them? Is this just common for biglakeiceberg?

c2thorn · 2026-02-26T22:43:34Z

 		if part != google.Underscore(apiPart) {
 			return false
 		}
+		if strings.Contains(apiPart, "-") {


@melinath can you take a quick peek at this change here

rambleraptor · 2026-03-02T22:47:33Z

@c2thorn I should've put my usual disclaimer on this PR!

The BigLake Iceberg resources have to conform to the Apache Iceberg REST Catalog Spec. This isn't a Google API standard at all. Our team has no control over this spec, but we have to follow it exactly or else we break users.

This ultimately means that there's a ton of custom code involved since MMv1 has a lot of Google assumptions baked in. It's really bit us on the last few Iceberg resources...

(background: The REST Catalog spec exists so that OSS engines like Apache Spark can talk to a variety of REST Catalogs - BigQuery, Databricks, Snowflake, other major companies - through a standard interface)

rambleraptor · 2026-03-03T17:05:27Z

@c2thorn changes made!

modular-magician · 2026-03-03T17:17:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 2941 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 12 files changed, 2941 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 793 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 284 insertions(+))

modular-magician · 2026-03-03T19:46:15Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableUpdateExample

Tests analytics

Total tests: 6113
Passed tests: 5464
Skipped tests: 639
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBiglakeIcebergIcebergTableIamBindingGenerated

TestAccBiglakeIcebergIcebergTableIamMemberGenerated

TestAccBiglakeIcebergIcebergTableIamPolicyGenerated

TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableBasicExample

TestAccBiglakeIcebergIcebergTable_update

TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate

TestAccOracleDatabaseCloudExadataInfrastructure_basic

TestAccOracleDatabaseCloudVmClusters_basic

TestAccOracleDatabaseDbNodes_basic

TestAccOracleDatabaseDbServers_basic

Get to know how VCR tests work

modular-magician · 2026-03-03T20:31:19Z

🟢 Tests passed during RECORDING mode:
TestAccBiglakeIcebergIcebergTableIamBindingGenerated [Debug log]
TestAccBiglakeIcebergIcebergTableIamMemberGenerated [Debug log]
TestAccBiglakeIcebergIcebergTableIamPolicyGenerated [Debug log]
TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableBasicExample [Debug log]
TestAccBiglakeIcebergIcebergTable_update [Debug log]
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmClusters_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccOracleDatabaseDbServers_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-03-05T09:56:38Z

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

c2thorn · 2026-03-05T18:15:51Z

/gcbrun

modular-magician · 2026-03-05T18:28:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 2941 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 12 files changed, 2941 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 793 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 284 insertions(+))

c2thorn · 2026-03-06T18:07:11Z

I think credentials got rotated during the build :[
I'm trying to get a fresh run to avoid transient VCR test failures

c2thorn · 2026-03-06T18:07:19Z

/gcbrun

modular-magician · 2026-03-06T18:24:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 2941 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 12 files changed, 2941 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 793 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 284 insertions(+))

modular-magician · 2026-03-06T20:47:38Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableUpdateExample

Tests analytics

Total tests: 6140
Passed tests: 5502
Skipped tests: 637
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate

Get to know how VCR tests work

modular-magician · 2026-03-06T21:22:08Z

🟢 Tests passed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

c2thorn

LGTM after reviewing how existing iceberg implementations.

c2thorn · 2026-03-06T23:12:44Z

@@ -0,0 +1,12 @@
+var icebergTableIgnoredProperties = map[string]bool{


If I were reviewing the other IcebergNamespace resource initially, maybe I would have pushed for separating out user-defined properties and server-defined properties into two separate fields. It's fine to suppress it this way in SDKv2 implementation, but it causes a data inconsistency that the newer Plugin Framework SDK doesn't like.

If this resource were ever to be migrated over to PF, we'd have to split this out.

considering we don't know when that would happen, and that IcebergNamespace was done very similarly, I'm opting to leave this as is.

c2thorn · 2026-03-06T23:15:20Z

updated release note

c2thorn

looks like there are still some unit test failures related to the metadata:

--- FAIL: TestValidateResourceMetadata (0.61s)
    resource_inventory_test.go:312: resource_biglake_iceberg_table_generated_meta.yaml: partition_spec.fields.name: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_table_generated_meta.yaml: partition_spec.fields.transform: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_table_generated_meta.yaml: schema.schema_id: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_catalog_generated_meta.yaml: catalog_type: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_catalog_generated_meta.yaml: create_time: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_catalog_generated_meta.yaml: credential_mode: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_catalog_generated_meta.yaml: default_location: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_catalog_generated_meta.yaml: storage_regions: `field` must be omitted because it can be inferred from `api_field`
    resource_inventory_test.go:312: resource_biglake_iceberg_catalog_generated_meta.yaml: update_time: `field` must be omitted because it can be inferred from `api_field`

c2thorn

unit test checks need to pass

modular-magician · 2026-03-09T22:23:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2929 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 11 files changed, 2929 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 793 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 284 insertions(+))

rambleraptor · 2026-03-09T23:09:20Z

@c2thorn changes made! It's looking like part of this is a mmv1 bug.

modular-magician · 2026-03-09T23:23:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 2929 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 12 files changed, 2929 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 793 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 284 insertions(+))

modular-magician · 2026-03-10T00:46:22Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableUpdateExample

Tests analytics

Total tests: 6141
Passed tests: 5500
Skipped tests: 639
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataformConfig_dataformConfigWithKmsKeyExample

TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate

Get to know how VCR tests work

modular-magician · 2026-03-10T01:22:48Z

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_dataformConfigWithKmsKeyExample [Debug log]
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_dataformConfigWithKmsKeyExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-03-10T01:46:36Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccBiglakeIcebergIcebergTable_biglakeIcebergTableUpdateExample

Tests analytics

Total tests: 6141
Passed tests: 5500
Skipped tests: 639
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataformConfig_dataformConfigWithKmsKeyExample

TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate

Get to know how VCR tests work

modular-magician · 2026-03-10T02:21:23Z

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_dataformConfigWithKmsKeyExample [Debug log]
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_dataformConfigWithKmsKeyExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

c2thorn

LGTM

c2thorn · 2026-03-10T13:50:53Z

 	tmp = regexp.MustCompile(`([a-z\d])([A-Z])`).ReplaceAllString(tmp, "${1}_${2}")
-	tmp = strings.Replace(tmp, "-", "_", 1)
-	tmp = strings.Replace(tmp, ".", "_", 1)
+	tmp = strings.ReplaceAll(tmp, "-", "_")


looks like this didn't have any non-iceberg side effects

Iceberg Table

ffd84b6

modular-magician added the service/bigquery label Feb 24, 2026

modular-magician requested a review from wj-chen February 24, 2026 23:45

fixes

a32f6ad

rambleraptor marked this pull request as ready for review February 26, 2026 18:22

github-actions bot requested a review from c2thorn February 26, 2026 18:23

c2thorn requested changes Feb 26, 2026

View reviewed changes

github-actions bot requested a review from c2thorn March 2, 2026 22:48

Changes for Iceberg Table

c52ec59

c2thorn approved these changes Mar 6, 2026

View reviewed changes

c2thorn reviewed Mar 6, 2026

View reviewed changes

c2thorn requested changes Mar 6, 2026

View reviewed changes

remove weird lineage change

ceaba71

github-actions bot requested a review from c2thorn March 9, 2026 22:11

test fixes

6851e9e

c2thorn approved these changes Mar 10, 2026

View reviewed changes

c2thorn added this pull request to the merge queue Mar 10, 2026

Merged via the queue into GoogleCloudPlatform:main with commit cfd244c Mar 10, 2026
23 of 24 checks passed

		@@ -0,0 +1,12 @@
		var icebergTableIgnoredProperties = map[string]bool{

Conversation

rambleraptor commented Feb 24, 2026 • edited by c2thorn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Feb 24, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Feb 25, 2026

Diff report

Uh oh!

modular-magician commented Feb 26, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

c2thorn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

c2thorn Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rambleraptor commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rambleraptor commented Mar 3, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Uh oh!

modular-magician commented Mar 3, 2026

Non-exercised tests

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

c2thorn commented Mar 5, 2026

Uh oh!

modular-magician commented Mar 5, 2026

Diff report

Uh oh!

c2thorn commented Mar 6, 2026

Uh oh!

c2thorn commented Mar 6, 2026

Uh oh!

modular-magician commented Mar 6, 2026

Diff report

Uh oh!

modular-magician commented Mar 6, 2026

Non-exercised tests

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 6, 2026

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

c2thorn Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

c2thorn commented Mar 6, 2026

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

rambleraptor commented Feb 24, 2026 •

edited by c2thorn

Loading

c2thorn left a comment •

edited

Loading

rambleraptor commented Mar 2, 2026 •

edited

Loading