Skip to content

Graduating Cloud Workstations resources from "google-beta" to "google" provider#16713

Merged
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
alexlucasdev:graduate-workstations-to-ga
Mar 23, 2026
Merged

Graduating Cloud Workstations resources from "google-beta" to "google" provider#16713
trodge merged 1 commit intoGoogleCloudPlatform:mainfrom
alexlucasdev:graduate-workstations-to-ga

Conversation

@alexlucasdev
Copy link
Copy Markdown
Contributor

This includes resources for: "Workstation", "WorkstationConfig", and "WorkstationCluster".

Updates API endpoint to point to "v1" endpoint instead of "v1beta" endpoint.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Graduated Workstation, WorkstationConfig, and WorkstationCluster resources from beta to GA provider.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 13, 2026
@alexlucasdev alexlucasdev force-pushed the graduate-workstations-to-ga branch from 5de5150 to c856a40 Compare March 17, 2026 16:08
@alexlucasdev alexlucasdev marked this pull request as ready for review March 17, 2026 16:10
@github-actions github-actions bot requested a review from trodge March 17, 2026 16:10
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@alexlucasdev alexlucasdev force-pushed the graduate-workstations-to-ga branch from c856a40 to af51a91 Compare March 17, 2026 16:12
@alexlucasdev alexlucasdev force-pushed the graduate-workstations-to-ga branch from af51a91 to 701b829 Compare March 17, 2026 16:34
@github-actions
Copy link
Copy Markdown

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/workstations and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 20, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 32 files changed, 10338 insertions(+), 101 deletions(-))
google-beta provider: Diff ( 16 files changed, 53 insertions(+), 387 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 15 insertions(+))
Open in Cloud Shell: Diff ( 23 files changed, 467 insertions(+), 50 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_workstations_workstation, google_workstations_workstation_cluster, google_workstations_workstation_config. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccWorkstationsWorkstationCluster_Private_update
  • TestAccWorkstationsWorkstationCluster_update
  • TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample
  • TestAccWorkstationsWorkstationCluster_workstationClusterCustomDomainExample
  • TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample
  • TestAccWorkstationsWorkstationCluster_workstationClusterTagsExample
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_basic
  • TestAccWorkstationsWorkstationConfig_boost
  • TestAccWorkstationsWorkstationConfig_disableTcpConnections
  • TestAccWorkstationsWorkstationConfig_displayName
  • TestAccWorkstationsWorkstationConfig_ephemeralDirectories
  • TestAccWorkstationsWorkstationConfig_ephemeralDirectories_withSourceImage
  • TestAccWorkstationsWorkstationConfig_persistentDirectories
  • TestAccWorkstationsWorkstationConfig_readinessChecks
  • TestAccWorkstationsWorkstationConfig_serviceAccount
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_updateHostDetails
  • TestAccWorkstationsWorkstationConfig_updatePersistentDirectorySourceSnapshot
  • TestAccWorkstationsWorkstationConfig_updateWorkingDir
  • TestAccWorkstationsWorkstationConfig_vmTags
  • TestAccWorkstationsWorkstationConfig_workstationConfigAcceleratorsExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigAllowedPortsExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigAllowedPortsUpdate
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigBoostExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigPersistentDirectoriesExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigShieldedInstanceConfigExample
  • TestAccWorkstationsWorkstationConfig_workstationConfigSourceSnapshotExample
  • TestAccWorkstationsWorkstationIamBindingGenerated
  • TestAccWorkstationsWorkstationIamMemberGenerated
  • TestAccWorkstationsWorkstationIamPolicyGenerated
  • TestAccWorkstationsWorkstation_update
  • TestAccWorkstationsWorkstation_workstationBasicExample

Tests analytics

Total tests: 38
Passed tests: 38
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • workstations

🟢 All tests passed!

View the build log

@alexlucasdev
Copy link
Copy Markdown
Contributor Author

Could a maintainer add the label "override-multiple-resources" ? This PR is graduating 3 deeply connected resources from google-beta to google provider. It is not adding any resources to the codebase. Between the dependency chain, tests and the actual usage I don't think splitting up the CL to graduate one resource at a time is feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants