Skip to content

Fix TcpRoute tests#16785

Merged
hao-nan-li merged 1 commit intoGoogleCloudPlatform:mainfrom
rostislavbobo:tcproute-load-balancing-scheme-fix
Mar 23, 2026
Merged

Fix TcpRoute tests#16785
hao-nan-li merged 1 commit intoGoogleCloudPlatform:mainfrom
rostislavbobo:tcproute-load-balancing-scheme-fix

Conversation

@rostislavbobo
Copy link
Copy Markdown
Member

Indicate correct load_balancing_scheme field and use correct google_compute_health_check resource for TCP Route tests. Previously, these tests used incompatible configurations.

Fixes hashicorp/terraform-provider-google#26465
Fixes hashicorp/terraform-provider-google#26464
Fixes hashicorp/terraform-provider-google#26462
Fixes hashicorp/terraform-provider-google#26460
Fixes hashicorp/terraform-provider-google#26456

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 64 insertions(+), 48 deletions(-))
google-beta provider: Diff ( 3 files changed, 82 insertions(+), 64 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 36 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 56 deletions(-))
google-beta provider: Diff ( 3 files changed, 82 insertions(+), 64 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 36 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 98
Passed tests: 87
Skipped tests: 6
Affected tests: 5

Click here to see the affected service packages
  • networkservices

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample
  • TestAccNetworkServicesTcpRoute_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 98
Passed tests: 87
Skipped tests: 6
Affected tests: 5

Click here to see the affected service packages
  • networkservices

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample
  • TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample
  • TestAccNetworkServicesTcpRoute_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample [Debug log]
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample [Debug log]
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample [Debug log]
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesTcpRoute_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@rostislavbobo rostislavbobo force-pushed the tcproute-load-balancing-scheme-fix branch from dca7ac4 to 724e841 Compare March 21, 2026 10:17
@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample [Debug log]
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample [Debug log]
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample [Debug log]
TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesTcpRoute_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@rostislavbobo rostislavbobo force-pushed the tcproute-load-balancing-scheme-fix branch from 724e841 to 49530ed Compare March 21, 2026 10:18
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 56 deletions(-))
google-beta provider: Diff ( 3 files changed, 91 insertions(+), 71 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 36 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 72 insertions(+), 56 deletions(-))
google-beta provider: Diff ( 3 files changed, 91 insertions(+), 71 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 36 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 98
Passed tests: 91
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesTcpRoute_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 98
Passed tests: 91
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesTcpRoute_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesTcpRoute_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesTcpRoute_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@hao-nan-li hao-nan-li added this pull request to the merge queue Mar 23, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 4124309 Mar 23, 2026
22 checks passed
zli82016 pushed a commit to zli82016/magic-modules that referenced this pull request Mar 31, 2026
carreter pushed a commit to carreter/magic-modules that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment