Skip to content

[MigrationCenter] Add persistent_disk_type to google_migration_center_preference_set#16844

Merged
ScottSuarez merged 1 commit intoGoogleCloudPlatform:mainfrom
modular-apprentice:auto-pr-1774562395833678366
Mar 31, 2026
Merged

[MigrationCenter] Add persistent_disk_type to google_migration_center_preference_set#16844
ScottSuarez merged 1 commit intoGoogleCloudPlatform:mainfrom
modular-apprentice:auto-pr-1774562395833678366

Conversation

@modular-apprentice
Copy link
Copy Markdown
Contributor

Adds the virtual_machine_preferences.compute_engine_preferences.persistent_disk_type field to the google_migration_center_preference_set resource to allow users to specify the persistent disk type.

migrationcenter: added `virtual_machine_preferences.compute_engine_preferences.persistent_disk_type` field to `google_migration_center_preference_set` resource

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 107 insertions(+))
google-beta provider: Diff ( 4 files changed, 107 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 120 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6
Passed tests: 5
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • migrationcenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccMigrationCenterPreferenceSet_preferenceSetComputeEnginePreferencesDiskTypeExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccMigrationCenterPreferenceSet_preferenceSetComputeEnginePreferencesDiskTypeExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants