Skip to content

Migrated Compute instance network interface to use transport_tpg.SendRequest#16848

Open
nsamartsev wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
nsamartsev:compute-instance-network-interface-migration
Open

Migrated Compute instance network interface to use transport_tpg.SendRequest#16848
nsamartsev wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
nsamartsev:compute-instance-network-interface-migration

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

@nsamartsev nsamartsev commented Mar 27, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `compute_instance_network_interface_helpers` resource to use direct HTTP rather than a client library

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 27, 2026
@nsamartsev nsamartsev marked this pull request as draft March 27, 2026 13:50
@github-actions github-actions bot requested a review from SirGitsalot March 27, 2026 13:50
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from 5fbdba7 to 6a0f1dc Compare March 27, 2026 14:13
@nsamartsev nsamartsev marked this pull request as ready for review March 27, 2026 14:14
@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch 2 times, most recently from 65eff06 to e41b3fb Compare March 30, 2026 14:32
@slevenick slevenick requested review from slevenick and removed request for SirGitsalot March 30, 2026 17:36
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 30, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 44 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 1 file changed, 58 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1398
Passed tests: 1305
Skipped tests: 90
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeInstance_PTRRecord
  • TestAccComputeInstance_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__access_config_update_access_config [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__two_access_config [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__two_access_config_update_policy_with_stopped_machine [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__two_nics_access_config_with_empty_nil_security_policy [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__two_nics_two_access_configs_update_one_policy [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__two_nics_two_access_configs_update_remove_access_config [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__two_nics_two_access_configs_update_two_policies [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy__wit_no_access_config [Debug log]
TestAccComputeInstance_PTRRecord [Debug log]
TestAccComputeInstance_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from e41b3fb to 030b44c Compare April 1, 2026 12:06
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 1, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 44 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 1 file changed, 58 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1403
Passed tests: 1313
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 2, 2026
@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from b44d3d9 to 1ca4c8c Compare April 2, 2026 15:35
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 2, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 60 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 74 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6239
Passed tests: 5592
Skipped tests: 644
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccProjectIamMemberRemove_memberInMultipleBindings

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from 1ca4c8c to d70fb69 Compare April 7, 2026 11:08
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 7, 2026
@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from d70fb69 to 6278825 Compare April 8, 2026 09:53
@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from 6278825 to be3118a Compare April 9, 2026 18:20
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 60 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 74 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6289
Passed tests: 5624
Skipped tests: 650
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccFolderIamPolicy_basic
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccFolderIamPolicy_basic [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccProjectIamMemberRemove_memberInMultipleBindings [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from be3118a to 7738457 Compare April 10, 2026 10:38
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 60 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 74 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6293
Passed tests: 5625
Skipped tests: 651
Affected tests: 17

Click here to see the affected service packages

All service packages are affected

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Error message] [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@nsamartsev nsamartsev force-pushed the compute-instance-network-interface-migration branch from 7738457 to 8b13ae8 Compare April 10, 2026 19:05
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 60 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 74 insertions(+), 21 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6293
Passed tests: 5627
Skipped tests: 651
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants