Skip to content

feat: Adds EntraID feature in Cloud SQL instances.#16896

Open
ajupazhamayil wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
ajupazhamayil:entraidconfig-in-sqldatabaseinstance
Open

feat: Adds EntraID feature in Cloud SQL instances.#16896
ajupazhamayil wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
ajupazhamayil:entraidconfig-in-sqldatabaseinstance

Conversation

@ajupazhamayil
Copy link
Copy Markdown

@ajupazhamayil ajupazhamayil commented Apr 1, 2026

Fixes hashicorp/terraform-provider-google#26698

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: added `entraid_config` field to `google_sql_database_instance` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 1, 2026
@ajupazhamayil ajupazhamayil force-pushed the entraidconfig-in-sqldatabaseinstance branch from ce00e63 to 5bfefb3 Compare April 1, 2026 09:41
@ajupazhamayil ajupazhamayil force-pushed the entraidconfig-in-sqldatabaseinstance branch from 5bfefb3 to 1e439e9 Compare April 8, 2026 15:22
@ajupazhamayil ajupazhamayil marked this pull request as ready for review April 8, 2026 15:40
@github-actions github-actions bot requested a review from hao-nan-li April 8, 2026 15:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/sqladmin-cp and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 8, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 183 insertions(+))
google-beta provider: Diff ( 4 files changed, 183 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (244 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    entraid_config {
      application_id = # value needed
      tenant_id      = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_sql_database_instance
    • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
    • Fields: [settings.entraid_config settings.entraid_config.application_id settings.entraid_config.tenant_id]

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 151
Passed tests: 122
Skipped tests: 28
Affected tests: 1

Click here to see the affected service packages
  • sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlDatabaseInstance_basicMSSQL_withEntraid

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_basicMSSQL_withEntraid [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

```release-note:enhancement
sql: added `entraid_config` fields to `google_sql_database_instance` resource
```

Fixes hashicorp/terraform-provider-google#26698
@ajupazhamayil ajupazhamayil force-pushed the entraidconfig-in-sqldatabaseinstance branch from 67e22b7 to 35f0418 Compare April 9, 2026 08:53
@ajupazhamayil
Copy link
Copy Markdown
Author

ajupazhamayil commented Apr 11, 2026

Hi @hao-nan-li, Could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/sqladmin-cp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add EntraidConfig to SqlDatabaseInstance resource

2 participants