feat: Adds EntraID feature in Cloud SQL instances.#16896
feat: Adds EntraID feature in Cloud SQL instances.#16896ajupazhamayil wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
ce00e63 to
5bfefb3
Compare
5bfefb3 to
1e439e9
Compare
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
settings {
entraid_config {
application_id = # value needed
tenant_id = # value needed
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 151 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
```release-note:enhancement sql: added `entraid_config` fields to `google_sql_database_instance` resource ``` Fixes hashicorp/terraform-provider-google#26698
67e22b7 to
35f0418
Compare
|
Hi @hao-nan-li, Could you please review this PR? |
Fixes hashicorp/terraform-provider-google#26698
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.