Skip to content

Promoting enable_emergent_maintenance to GA and setting to optional as this is not required #16916

Open
NA2047 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
NA2047:emOptional
Open

Promoting enable_emergent_maintenance to GA and setting to optional as this is not required #16916
NA2047 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
NA2047:emOptional

Conversation

@NA2047
Copy link
Copy Markdown
Contributor

@NA2047 NA2047 commented Apr 2, 2026

This is supported in the update and does not require a recreation in gcloud

https://docs.cloud.google.com/compute/docs/reference/rest/v1/reservations/update

compute: added `enable_emergent_maintenance` to `resource_compute_reservation` (GA)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 31 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 11 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 21 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1403
Passed tests: 1313
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@NA2047 NA2047 changed the title Promoting to enable_emergent_maintenance to GA and setting to optional as this is not required Promoting enable_emergent_maintenance to GA and setting to optional as this is not required Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@shuyama1
Copy link
Copy Markdown
Member

shuyama1 commented Apr 9, 2026

@modular-magician reassign-reviewer shuyama1

@github-actions github-actions bot requested review from shuyama1 and removed request for malhotrasagar2212 April 9, 2026 19:10
Copy link
Copy Markdown
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NA2047 I do see this field in the test mmv1/templates/terraform/examples/reservation_basic_beta.tf.tmpl. Would it be possible to promote that test (if it doesn't contain other beta-only field) and also add an update test for it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants