Promoting enable_emergent_maintenance to GA and setting to optional as this is not required #16916
Promoting enable_emergent_maintenance to GA and setting to optional as this is not required #16916NA2047 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
enable_emergent_maintenance to GA and setting to optional as this is not required #16916Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1403 Click here to see the affected service packages
🟢 All tests passed! View the build log |
enable_emergent_maintenance to GA and setting to optional as this is not required enable_emergent_maintenance to GA and setting to optional as this is not required
|
@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
@modular-magician reassign-reviewer shuyama1 |
shuyama1
left a comment
There was a problem hiding this comment.
@NA2047 I do see this field in the test mmv1/templates/terraform/examples/reservation_basic_beta.tf.tmpl. Would it be possible to promote that test (if it doesn't contain other beta-only field) and also add an update test for it? Thanks!
This is supported in the update and does not require a recreation in gcloud
https://docs.cloud.google.com/compute/docs/reference/rest/v1/reservations/update